Fix: Semver filtering should preserv "v" prefix if specified #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
olblak
changed the title
1 task
dduportal
added a commit
to dduportal/updatecli
that referenced
this pull request
Aug 22, 2022
…ed filtered version Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
added a commit
to dduportal/updatecli
that referenced
this pull request
Aug 22, 2022
…ed filtered version Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
added a commit
to dduportal/updatecli
that referenced
this pull request
Aug 23, 2022
…ed filtered version Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
olblak
added a commit
that referenced
this pull request
Aug 24, 2022
…ed version (#816) * feat: add a new 'experimental' flag Signed-off-by: Damien Duportal <damien.duportal@gmail.com> * feat: revert #802 and use experimental to control the returned filtered version Signed-off-by: Damien Duportal <damien.duportal@gmail.com> Signed-off-by: Damien Duportal <damien.duportal@gmail.com> Co-authored-by: Olivier Vernin <olivier@vernin.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #803
When using the versionFilter of kind "semver", we drop the prefix "v" if one exist in the source such as the latest version of the following list ["v1.0.0", "v2.0.0"] would return "2.0.0" instead of "v2.0.0"
Test
To test this pull request, you can run the following commands:
Source output should show
Additional Information
Tradeoff
This is a long running issue, so we'll quite a few updatecli manifest to fix manually :(
Potential improvement