Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsonschema library to 0.6.0 #804

Merged
merged 2 commits into from
Aug 13, 2022
Merged

Conversation

olblak
Copy link
Member

@olblak olblak commented Aug 12, 2022

Superseed #799

The jsonschema library used in Updatecli removed YAML tag support to focus on JSON tag. As far as I could see it doesn't impact updatecli because we didn't leverage YAML tag but it's hard to say for sure. The generated jsonschema is pretty big,

Test

/

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak enabled auto-merge (squash) August 12, 2022 19:07
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@olblak olblak merged commit 719c2eb into updatecli:main Aug 13, 2022
@olblak olblak added the dependencies Pull requests that update a dependency file label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants