-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: [s][c][t] Add xml resource plugin #823
Conversation
Signed-off-by: Olblak <me@olblak.com>
@jetersen I may have found an integrated solution |
Combined with the autodiscovery feature introduced in "#763", we could automate pom.xml |
If you want we can easily test it on Jenkinsci/bom since manifests are generated |
Seems to working. I created this pullrequest https://github.com/olblak/bom/pull/1/files
|
@hervelemeur If you have some time, I would appreciate your review on this PR as you are pretty good at catching things I don't see |
Imho the PR is ready to be merged |
I am moving forward so I can already start using this in production |
Erf, I had some (small) suggestions indeed, too late. |
Signed-off-by: Olblak me@olblak.com
Fix #371
This pullrequest is a second attempt after #336
This time I am leveraging https://github.com/beevik/etree library
It went smoothly, and after some testing, I didn't notify any major change done to the xml file after an update
Accept spec parameters are:
Test
To test this pull request, you can run the following commands:
The path accept xpath query such as https://docs.python.org/3/library/xml.etree.elementtree.html#supported-xpath-syntax:w
Note that I didn't test all of them.
Additional Information
Tradeoff
/
Potential improvement
/