-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add Autodiscovery for Maven dependencies #833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
olblak
added
enhancement
New feature or request
resource-mavenrepository
Resource of kind Maven Repository
autodiscovery
All things related to the autodiscovery feature
labels
Aug 29, 2022
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
…from pom.xml Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
1 task
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
I'll look to the credentials in a different PR. I am gonna merge the PR so I can already start testing it widely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autodiscovery
All things related to the autodiscovery feature
enhancement
New feature or request
resource-mavenrepository
Resource of kind Maven Repository
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #XXX
Test
To test this pull request, you can run the following commands:
Scenario 1
Scenario 2
Additional Information
This crawler can be used such as
Tradeoff
After additional thoughts on how to handle credentials, I came to the conclusion that it would be easier to expose some parameter to provide credentials mapping repositories then trying to fetch those credentials from settings.xml
Potential improvement