fix: Correctly retrieve GitHub enterprise url

[olblak]

Signed-off-by: Olblak me@olblak.com

Fix #854

Test

To test this pull request, you can run the following commands:

# Build binary using Golang 1.19
go build -o bin/updatecli .
# Test using a manifest
./bin/updatecli diff --config updatecli/updatecli.d

Additional Information

Tradeoff

I don't have access to a GitHub enterprise service to test. But we probably just read to quickly this doc https://github.com/shurcooL/githubv4#usage

Potential improvement

[gerardsegarra]

Oh, I see you've already been working on it. I just created this PR #859, but I'm not an expert either in golang or updatecli code :P

[olblak]

Oh, I see you've already been working on it. I just created this PR #859, but I'm not an expert either in golang or updatecli code :P

Your PR is better as it has tests, so I'll do some suggestion to yours :p

[olblak]

@gerardsegarra In the end I think my PR is in a more advanced state even thought we had the same thing in mind.

I improved the spec so we can also specify http protocol in the URL. If no protocol is specified then it fallbacks to https

Additional work would be needed if we want to allow the ssh:// protocol

[lemeurherve]

GitHub correct case (nit)
LGTM otherwise

[olblak]

Thanks @lemeurherve for the review and thanks @gerardsegarra for spotting this issues

[gerardsegarra]

Thank you so much for fixing it! 😄