Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helmfile autodiscovery crawler #878

Merged
merged 7 commits into from
Sep 22, 2022

Conversation

olblak
Copy link
Member

@olblak olblak commented Sep 19, 2022

Signed-off-by: Olblak me@olblak.com

Fix #409

This pullrquest add the helmfile autodiscovery crawler.
By default it searches for all files matching [".yaml", ".yml"] if the crawler identify the following pattern in the file

repositories:
 - ...
releases:
 - ...

So it assumes that the repository used by a release is defined in the same file.

Test

To test this pull request, you can run the following commands:

# Unit Test
cd pkg/plugins/autodiscovery/helmfile
go test

## End to End test
go build -o bin/updatecli .
./bin/updatecli diff --config e2e/updatecli.d/warning.d/autodiscovery/helmfile --experimental --debug

Additional Information

Tradeoff

In order to be detected by Updatecli helmfile releases requires the following rules

  1. A release and its repository must be located in the same file
  2. A version must be specified for a release

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added the autodiscovery All things related to the autodiscovery feature label Sep 19, 2022
@olblak olblak marked this pull request as draft September 19, 2022 20:24
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak marked this pull request as ready for review September 20, 2022 06:47
@olblak
Copy link
Member Author

olblak commented Sep 20, 2022

I am still missing UT to catch edgecases but at least it's already working and can be tested

Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak merged commit 943fe6a into updatecli:main Sep 22, 2022
@olblak olblak deleted the helmfileAutodiscovery branch September 22, 2022 06:34
@olblak olblak added the enhancement New feature or request label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodiscovery All things related to the autodiscovery feature enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: update all charts of an helmfile without having to create a manifest of each of them
1 participant