Add Toml support #889
Merged
Add Toml support #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
|
I need to test if Dasel preserve Toml comments |
Well it doesn't |
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
olblak
commented
Sep 26, 2022
olblak
commented
Sep 26, 2022
olblak
commented
Sep 26, 2022
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
|
I played a bit with the multiple update which is super powerfull. I already works for target, I'll add support for condition but I don't think of a usage for source |
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
|
Well after additional thought, I think I need a new boolean to enable/disable the multiple query because in the case of the following query, we can't guess automatically the meaning Should
I am considering adding a spec parameter named "multipe" to enable multiple query, with default set to false |
Signed-off-by: Olblak <me@olblak.com>
|
So I decided to add the flag |
Signed-off-by: Olblak <me@olblak.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olblak me@olblak.com
Add support to toml for source/condition/target
#870
Fix #XXX
Test
To test this pull request, you can run the following commands:
cp pkg/plugins/resources/toml go testAdditional Information
Tradeoff
Same approach than #885
I am leveraging Dasel
Potential improvement