Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi file support to Json/Toml/csv resource #899

Merged
merged 13 commits into from
Oct 4, 2022
Merged

Add multi file support to Json/Toml/csv resource #899

merged 13 commits into from
Oct 4, 2022

Conversation

olblak
Copy link
Member

@olblak olblak commented Sep 30, 2022 •
edited

  • Add multi file support to Json/Toml/Csv resource
  • Refactor Json resource to create an intermediate package named Dasel which could be reused for the csv and toml resource
    • github.com/updatecli/updatecli/pkg/plugins/utils/dasel"

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

@olblak
Add dasel util package
3d9d906 
Signed-off-by: Olblak <me@olblak.com>
@olblak
Refactor json package
bbe3cd1 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added enhancement New feature or request resource-json labels Sep 30, 2022
@olblak olblak marked this pull request as draft September 30, 2022 19:30
@olblak
Update json e2e tests
5043195 
Signed-off-by: Olblak <me@olblak.com>
@olblak
json should return error if query do not exist
cf757bc 
Signed-off-by: Olblak <me@olblak.com>
@olblak
Add toml support to dasel package
ca3bca6 
Signed-off-by: Olblak <me@olblak.com>
@olblak
Add files support to toml
5bf7ba6 
Refactor toml to use dasel package

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak changed the title Add multi file support to Json resource Add multi file support to Json/Toml resource Sep 30, 2022
@olblak
Export dasel helper function
c2b63a9 
Signed-off-by: Olblak <me@olblak.com>
@olblak
Fix toml spec comment
75009c9 
Signed-off-by: Olblak <me@olblak.com>
@olblak
Fix json spec comment
4a704ad 
Signed-off-by: Olblak <me@olblak.com>
@olblak
Add multi files support to csv
c4b30be 
Refactor csv resource to use custom dasel package

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak marked this pull request as ready for review October 3, 2022 07:35
@olblak olblak changed the title Add multi file support to Json/Toml resource Add multi file support to Json/Toml/csv resource Oct 3, 2022
@olblak
Add csv spec validation
d3b39ac 
Signed-off-by: Olblak <me@olblak.com>
@olblak
reword error message
3ba7a6b 
Signed-off-by: Olblak <me@olblak.com>
@olblak
Add back csv write function
8bfe210 
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak merged commit 7f70e4c into updatecli:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request resource-csv resource-json resource-toml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@olblak