Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pullrequest): default title with the source output instead of its result '✔' #955

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Oct 27, 2022

Fix
image

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

I intend to improve this pull request default title by including the name of what's updated, and maybe also the type.

Something like

[updatecli] Bump <name> <helm chart|docker image|...> version to

The easiest way I found to retrieve the name would be to use sources[0].name, implying the change of (jenkins infra) manifests (they almost all have a description in the name field)

@olblak
Copy link
Member

olblak commented Oct 27, 2022

I intend to improve this pull request default title by including the name of what's updated, and maybe also the type.
I think it would only work if the pullrquest only depends on one source. Otherwise it can be confusing.

Copy link
Member

@olblak olblak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I am surprised that this bug lived for so long :o

@lemeurherve
Copy link
Member Author

lemeurherve commented Oct 27, 2022

I think it would only work if the pullrquest only depends on one source. Otherwise it can be confusing.

Yes there will be special cases.
I intend to respond to the common cases mainly (like one source) and fallback to a default title like the current one otherwise.

@olblak
Copy link
Member

olblak commented Oct 28, 2022

I think it would only work if the pullrquest only depends on one source. Otherwise it can be confusing.

Yes there will be special cases. I intend to respond to the common cases mainly (like one source) and fallback to a default title like the current one otherwise.

Is this something you want to implement in this PR?
Imho the current one is ready to be ship, I am planning to trigger a release next week

@lemeurherve
Copy link
Member Author

Is this something you want to implement in this PR?

No. 🚢

@lemeurherve lemeurherve merged commit 1d30975 into updatecli:main Oct 28, 2022
@lemeurherve lemeurherve deleted the default-pullrequest-title branch October 28, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pullrequest source ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants