-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[source][condition] Allow to filter Github Release per release type #969
Conversation
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
After thinking more about this PR. We keep the current deprecate behavior only if no release type have been specified and we couldn't find a release. |
refactor a bit Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
This reverts commit 1978ffd.
Signed-off-by: Olblak <me@olblak.com>
As part @lemeurherve @dduportal feedback, I revert the last commit and changed the key from |
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
A quick comment to confirm that this PR introduces a regression to the GH releases filtering when using a regexp (at least) filter. The manifest https://github.com/jenkinsci/docker-agent/blob/master/updatecli/updatecli.d/jdk11.yaml allows to reproduce the issue:
I'm going to run a debuger to understand why is the regression. |
Ok, got the issue: it seems that the default values when |
Allow to filter GitHub Release per release type (draft,prelease,release,latest)
I am also adding the missing Github Release condition
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
For historical reason #196
The Github Release fallback to searching Git Tag if no GitHub release could be found.
This behavior is incompatible with filter release by tag as it would return the latest git tag if no release could be found matching release type.
To not introduce breaking change, I am introducing the parameter
disabletagsearch
which can be set to true to enforce the new behavior. This parameter will be remove in a futur release once we are ready to remove the old behavior.Potential improvement