Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent target execution #984

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Fix parent target execution #984

merged 1 commit into from
Nov 16, 2022

Conversation

macedogm
Copy link
Contributor

Fix #983

Test

N/A

Additional Information

Tradeoff

N/A

Potential improvement

N/A

Signed-off-by: Guilherme Macedo guilherme.macedo@suse.com

Signed-off-by: Guilherme Macedo <guilherme.macedo@suse.com>
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the detailed issue and the fix!

@dduportal dduportal added bug Something isn't working target Related to updatecli target labels Nov 15, 2022
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a nice catch, thanks for this fix!

@dduportal
Copy link
Contributor

Ping @olblak can we let you merge based on how you want to release next versions?

@olblak
Copy link
Member

olblak commented Nov 16, 2022

Thanks for the PR and the reviews.
I am ready to merge this PR
Regarding a new release, we can either trigger a release now or wait until the weekend.
Unless @macedogm the current bug affect you, I would prefer waiting for the weekend :)

@olblak olblak merged commit daddd7a into updatecli:main Nov 16, 2022
@macedogm
Copy link
Contributor Author

@olblak thanks for merging it. I'm fine in waiting until the weekend.

@macedogm macedogm deleted the 983-fix-parent-target branch November 16, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working target Related to updatecli target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependent target fails to execute when parent target runs successfully with standard output non-empty
4 participants