feat(dockerimage condition) supports a list of architectures

[dduportal]

Fix #962

This PR introduces a new feature for the conditions of the resource dockerimage.
You can now specify a list of architectures instead of a single one, to simplify the manifests.

Not valid for sources (sources are not multi-valued) and targets (same). @olblak is there a way to tune the JSON schema to avoid it to proposes architectures for sources and targets?

Test

To test this pull request, you can run the following commands:

make build test

Example:

checkTemurinDebianDockerImage:
    kind: dockerimage
    name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-focal" is available
    disablesourceinput: true
    spec:
      architectures:
        - amd64
        - arm64
        - arm/v7
        - s390x
      image: eclipse-temurin
      tag: '{{source "lastVersion" }}-jdk-focal'

returns:

CONDITIONS:
===========

checkTemurinDebianDockerImage
----------------------------------
✔ The Docker image index.docker.io/library/eclipse-temurin:11.0.16.1_1-jdk-focal (amd64) exists and is available.
✔ The Docker image index.docker.io/library/eclipse-temurin:11.0.16.1_1-jdk-focal (arm64) exists and is available.
✔ The Docker image index.docker.io/library/eclipse-temurin:11.0.16.1_1-jdk-focal (arm/v7) exists and is available.
✔ The Docker image index.docker.io/library/eclipse-temurin:11.0.16.1_1-jdk-focal (s390x) exists and is available.

Additional Information

Tradeoff

Writing looooooong manifests?

checkTemurinDebianDockerImageAmd64:
    kind: dockerimage
    name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-focal" is available
    disablesourceinput: true
    spec:
      architecture: amd64
      image: eclipse-temurin
      tag: '{{source "lastVersion" }}-jdk-focal'
checkTemurinDebianDockerImageArm64:
    kind: dockerimage
    name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-focal" is available
    disablesourceinput: true
    spec:
      architecture: arm64
      image: eclipse-temurin
      tag: '{{source "lastVersion" }}-jdk-focal'
  checkTemurinDebianDockerImages390x:
    kind: dockerimage
    name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-focal" is available
    disablesourceinput: true
    spec:
      architecture: s390x
      image: eclipse-temurin
      tag: '{{source "lastVersion" }}-jdk-focal'
  checkTemurinDebianDockerImagesArmv7:
    kind: dockerimage
    name: Check if the container image "eclipse-temurin:<lastVersion>-jdk-focal" is available
    disablesourceinput: true
    spec:
      architecture: arm/v7
      image: eclipse-temurin
      tag: '{{source "lastVersion" }}-jdk-focal'

Potential improvement

• Deprecate the current parameter architecture in favor of the plural form (requires a validation rule for sources and target though)
• Support of both OS and architectures

[olblak]

Deprecate the current parameter architecture in favor of the plural form (requires a validation rule for sources and target though)

I wouldn't do that since multiple architecture is not supported for sources.
And there is not dockerimage target.

Support of both OS and architectures
I thought you wanted to use "platform". The same approach than docker-compose files

Anyway the current PR is already a great one and complementary with my ongoing effort with docker-compose
I let you merge it if you are happy

[dduportal]

Deprecate the current parameter architecture in favor of the plural form (requires a validation rule for sources and target though)

I wouldn't do that since multiple architecture is not supported for sources. And there is not dockerimage target.

👍

[dduportal]

Support of both OS and architectures
I thought you wanted to use "platform". The same approach than docker-compose files

Yes I do, but it is another PR (different subject than here).

Anyway the current PR is already a great one and complementary with my ongoing effort with docker-compose I let you merge it if you are happy

❤️