New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable default autodiscovery if no manifest provided #987

Merged

olblak merged 6 commits into updatecli:main from olblak:autoDiscoveryDefault

Nov 19, 2022

Member

olblak commented Nov 17, 2022 •

edited

Signed-off-by: Olblak me@olblak.com

Fix #XXX

Running updatecli manifest show, updatecli diff , updatecli apply, now enable autodiscovery if no manifest were provided

Test

To test this pull request, you can run the following commands:

go build -o /tmp/updateCli
cd $HOME
/tmp/updateCli show  --experimental

Additional Information

Tradeoff

I decided to not remove the parameter --local-autodiscovery Local AutoDiscovery feature enabled as I feel it will still be useful in the futur

Potential improvement

Remove the experimental flag for autodiscovery, I think we are getting there


          enable default autodiscovery if no manifest provided

d12e300

Signed-off-by: Olblak <me@olblak.com>

olblak added the autodiscovery label

olblak and others added 5 commits

November 19, 2022 08:49


          Merge branch 'main' into autoDiscoveryDefault

12a6921


          Correctly handle no error

c2865dc

Signed-off-by: Olblak <me@olblak.com>


          Merge branch 'autoDiscoveryDefault' of github.com:olblak/updatecli in…

1772cda

…to autoDiscoveryDefault


          rephrase when no manifest detected

2a489d7

Signed-off-by: Olblak <me@olblak.com>


          Merge branch 'main' into autoDiscoveryDefault

7fb70c4

olblak added the enhancement label

olblak merged commit b86e3aa into updatecli:main

olblak deleted the autoDiscoveryDefault branch

November 19, 2022 15:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment