Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set version when updating yaml array list #99

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Correctly set version when updating yaml array list #99

merged 1 commit into from
Oct 20, 2020

Conversation

olblak
Copy link
Member

@olblak olblak commented Oct 20, 2020 •
edited

Fix #98
We weren't updating the new value in the case of an array list which looks like:

array:
- value0
- value1

Signed-off-by: Olivier Vernin olivier@vernin.me

@olblak
Correctly set version to yaml array
c2f89c8 
Signed-off-by: Olivier Vernin <olivier@vernin.me>
@olblak olblak changed the title Correctly set version to yaml array Correctly set version when updating yaml array list Oct 20, 2020
@olblak olblak added the bug Something isn't working label Oct 20, 2020
jetersen
jetersen approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olblak olblak merged commit a9a0c3a into master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

array position value is not updated.
2 participants
@olblak @jetersen