Merge @upfluence/oss package into this project #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phndiaye
requested review from
tgallice,
Miexil,
JulienVannier66 and
a team
as code owners
phndiaye
force-pushed
the
pn/deprecate-oss-package
branch
from
16562cf
to
8fdb019
Compare
Miexil
approved these changes
Aug 3, 2022
app/styles/base/_all.less
Outdated
| @import '_progress'; | ||
| @import '_slider'; | ||
| @import '_stats'; | ||
| @import '_tables'; // TO_BE_DEPRECIATED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For some time now, we have noticed that the split between this package (holding Ember specific code) and @upfluence/oss package (holding more agnostic, Less CSS + assets only code) is not viable anymore and brings some pain point that are a bit annoying:
After discussion w/ the team, this PR brings the CSS, assets and deps from the @upfluence/oss package into @upfluence/oss-components definitely.
What are the observable changes?
Good PR checklist
Additional Notes