Decode to utf8 #20
Merged
Decode to utf8 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgallice
force-pushed
the
tg-decode-utf8
branch
from
fec549d
to
1e8cfd3
Compare
stringutil/decoder_test.go
Outdated
|
|
||
| func TestDecodeToUTF8(t *testing.T) { | ||
| for _, testcase := range []struct { | ||
| Value string |
There was a problem hiding this comment.
does it need to be a public variable?
There was a problem hiding this comment.
you squash those two lines, in, out string
upfluence-bot
added
reviewed/needs-work
and removed
reviewed/needs-review
reviewed/needs-work
labels
stringutil/decoder.go
Outdated
| return s | ||
| } | ||
|
|
||
| s, err := charmap.ISO8859_1.NewDecoder().String(s) |
There was a problem hiding this comment.
should we store the decoder in a variable instead of instanciate it every time
stringutil/decoder.go
Outdated
| s, err := charmap.ISO8859_1.NewDecoder().String(s) | ||
|
|
||
| if err != nil { | ||
| return "" |
There was a problem hiding this comment.
should we log the error ?
upfluence-bot
added
reviewed/needs-work
reviewed/needs-review
and removed
reviewed/needs-work
labels
stringutil/decoder.go
Outdated
| "github.com/upfluence/pkg/log" | ||
| ) | ||
|
|
||
| var default_decoder = charmap.ISO8859_1.NewDecoder() |
tgallice
force-pushed
the
tg-decode-utf8
branch
from
4e6f92b
to
8112541
Compare
upfluence-bot
added
reviewed/needs-review
and removed
reviewed/needs-work
reviewed/needs-review
labels
AlexisMontagne
approved these changes
Nov 1, 2017
stringutil/decoder.go
Outdated
| var defaultDecoder = charmap.ISO8859_1.NewDecoder() | ||
|
|
||
| func DecodeToUTF8(s string) string { | ||
| if s == "" { |
stringutil/decoder_test.go
Outdated
| {"test", "test"}, | ||
| {"testé", "testé"}, | ||
| {"test\xc3", "testÃ"}, | ||
| {"\xc3", "Ã"}, |
There was a problem hiding this comment.
you need to also test the case where it's a non standard set of bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.