Cache/policy/time: Backup next before deleting current list elem #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlevesy
approved these changes
Oct 28, 2021
cache/policy/time/policy.go
Outdated
Comment on lines
162
to
164
| next := e.Next() | ||
| p.l.Remove(e) | ||
| e = next |
There was a problem hiding this comment.
can you do that before notifying the cache?
upfluence-bot
added
reviewed/needs-work
and removed
reviewed/ready-to-merge
reviewed/needs-work
labels
Sypheos
force-pushed
the
1086/cache-policy-leak
branch
from
1d06966
to
3f64b31
Compare
AlexisMontagne
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix an issue with the time policy that prevent it from evicting more than one element at a time.
Fixes https://github.com/upfluence/backlog/issues/1086
What are the observable changes?
backup next before deleting current
Good PR checklist
Additional Notes