Update and expand documentation about currencies and other assets #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waldyrious
force-pushed
the
support/update-currency-code-docs
branch
from
c119a8d
to
6d646b2
Compare
waldyrious
changed the title
waldyrious
force-pushed
the
support/update-currency-code-docs
branch
from
6d646b2
to
3e956cc
Compare
Americas
reviewed
Oct 16, 2020
waldyrious
force-pushed
the
support/update-currency-code-docs
branch
from
3e956cc
to
18325c5
Compare
Americas
reviewed
Oct 16, 2020
waldyrious
force-pushed
the
support/update-currency-code-docs
branch
from
18325c5
to
4d82b9b
Compare
ruimarinho
reviewed
Oct 22, 2020
ruimarinho
reviewed
Oct 22, 2020
ruimarinho
reviewed
Oct 22, 2020
ruimarinho
reviewed
Oct 22, 2020
ruimarinho
reviewed
Oct 22, 2020
ruimarinho
reviewed
Oct 22, 2020
ruimarinho
reviewed
Oct 22, 2020
ruimarinho
reviewed
Oct 22, 2020
ruimarinho
reviewed
Oct 22, 2020
waldyrious
force-pushed
the
support/update-currency-code-docs
branch
from
4d82b9b
to
aac6359
Compare
waldyrious
changed the title
Comment on lines
+114
to
+115
| Transactions made with assets in this status will settle instantly for the user, | ||
| but will have a higher spread, as Uphold takes financial risk to provide this service. |
There was a problem hiding this comment.
Not sure that, from the business perspective, we want to say this. Should we validate this with someone from business?
There was a problem hiding this comment.
Thanks for the careful review :) This phrasing has been validated by Product, and is also the language we use in the FAQ, so I think we're good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assetsendpoint.