Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to pnpm #195

Closed
karlhorky opened this issue Feb 11, 2023 · 0 comments 路 Fixed by #203
Closed

Switch to pnpm #195

karlhorky opened this issue Feb 11, 2023 · 0 comments 路 Fixed by #203

Comments

@karlhorky
Copy link
Member

karlhorky commented Feb 11, 2023 •
edited

pnpm benefits:

  1. Faster installation approach
  2. Does not seem to require "resolutions" in package.json for ESLint plugin deduplication 馃檶 Deduplication and module resolution happens in a compatible way for ESLint

Example of resolutions removal working with ESLint, even when non-matching

  1. "resolutions" removed in karlhorky/github-actions-database-persistence@c3a909a
  2. older and newer versions of various ESLint dependencies added in karlhorky/github-actions-database-persistence@10770bd

Both of these passed their linting checks:

Screenshot 2023-02-11 at 13 53 56
@karlhorky karlhorky mentioned this issue Feb 11, 2023
Closed
karlhorky added a commit to karlhorky/github-actions-database-persistence that referenced this issue Feb 11, 2023
@karlhorky
Use different versions of ESLint dependencies
10770bd 
To test if resolutions is needed still with pnpm to resolve issues with
incompatible versions of ESLint plugins

Ref: upleveled/eslint-config-upleveled#195
@karlhorky karlhorky mentioned this issue Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from Yarn to pnpm (#203 upleveled/eslint-config-upleveled
1 participant
@karlhorky