Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency cypress to v10 (solution) #179

Merged
merged 7 commits into from
Jul 1, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 2, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
cypress 9.7.0 -> 10.3.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "after 4pm on thursday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/solution-cypress-10.x branch from db64e48 to 83b21ad Compare June 3, 2022 01:06
@karlhorky
Copy link
Member

karlhorky commented Jun 3, 2022

Ah these need to be updated (also the instructions):

yarn lint

/home/runner/work/sad-machine-codealong/sad-machine-codealong/cypress.config.ts
Warning:   5:21  warning  'on' is defined but never used      @typescript-eslint/no-unused-vars
ESLint found too many warnings (maximum: 0).
Warning:   5:25  warning  'config' is defined but never used  @typescript-eslint/no-unused-vars
✖ 2 problems (0 errors, 2 warnings)

yarn tsc

util/__tests__/openWeatherMap.test.ts:60:48 - error TS2551: Property 'toEqual' does not exist on type 'Assertion'. Did you mean 'equal'?

60   expect(transform(openWeatherMapResponse200)).toEqual({
                                                  ~~~~~~~

  node_modules/cypress/types/chai/index.d.ts:206:9
    206         equal: Equal;
                ~~~~~
    'equal' is declared here.

util/__tests__/openWeatherMap.test.ts:73:48 - error TS2339: Property 'toMatchSnapshot' does not exist on type 'Assertion'.

73   expect(transform(openWeatherMapResponse401)).toMatchSnapshot();
                                                  ~~~~~~~~~~~~~~~

util/__tests__/openWeatherMap.test.ts:77:48 - error TS2339: Property 'toMatchSnapshot' does not exist on type 'Assertion'.

77   expect(transform(openWeatherMapResponse404)).toMatchSnapshot();
                                                  ~~~~~~~~~~~~~~~


Found 3 errors in the same file, starting at: util/__tests__/openWeatherMap.test.ts:60

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This is a problem related to the new Cypress 10 types cypress-io/cypress#22059

@karlhorky karlhorky merged commit 251f1cd into solution Jul 1, 2022
@karlhorky karlhorky deleted the renovate/solution-cypress-10.x branch July 1, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants