Moved deep_update from pydantic to pyuploadcare.helpers #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsedykh
approved these changes
Feb 29, 2024
evgkirov
force-pushed
the
bugfix/283-deprecated_deep_update
branch
from
1ccd213
to
3ee178c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #283
There are two instances of
deep_updatein the Pydantic v2 codebase that we could import. However:pydantic.v1.utils.deep_updatefunction could be removed in the future.pydantic._internal._utils.deep_updatefunction is clearly marked for internal use.So I had to copy-paste this function into our library (Pydantic is MIT licensed, so no problem here).
Checklist