Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transformations/image.py #292

Merged
merged 18 commits into from
Apr 9, 2024
Merged

Conversation

evgkirov
Copy link
Collaborator

Description

Related issue: #267

Added

Changed

  • For ImageTransformation:
    • The overlay() and overlay_self() methods now treat overlay_width and overlay_height parameters as optional.
    • Unified gif2video(), gif2video_format(), and gif2video_quality() methods into a single gif2video() method. The format and quality parameters can now be accepted directly in the gif2video() method.

Deprecated

  • For ImageTransformation:
    • Deprecated the separate gif2video_format and gif2video_quality methods. Please use the format and quality parameters directly in the gif2video method for setting these properties.

Checklist

Copy link
Member

@dmitry-mukhin dmitry-mukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed.
lgtm.

@evgkirov evgkirov force-pushed the feature/267-update_transformations branch from 695e74a to 15e6bf7 Compare April 9, 2024 11:27
@evgkirov evgkirov merged commit d85a26c into main Apr 9, 2024
33 checks passed
@evgkirov evgkirov deleted the feature/267-update_transformations branch April 9, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants