Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delete method for Uploadcare::File #103

Merged

Conversation

T0mbery
Copy link
Contributor

@T0mbery T0mbery commented Sep 22, 2022

Description

Checklist

@dmitrijivanchenko
Copy link
Contributor

dmitrijivanchenko commented Sep 28, 2022

Тут надо обязательно пометить в ридми или changelog рельсовой либы c восклицательными знаками, что после вкатывания этого ПР в рельсовой либе сломается удаление файлов.

@T0mbery T0mbery force-pushed the remove_delete_method_for_file branch from cd9bba7 to 7665496 Compare September 29, 2022 18:39
@T0mbery T0mbery force-pushed the remove_store_method_for_rest_group branch from 4ed1491 to 80ffe58 Compare September 29, 2022 18:53
@T0mbery T0mbery force-pushed the remove_delete_method_for_file branch from 7665496 to 03c8e1b Compare September 29, 2022 19:00
@T0mbery
Copy link
Contributor Author

T0mbery commented Sep 29, 2022

тут изначально ошибка произошла.
нужно было не удалить метод, а просто поменять его урл на /files/{uuid}/storage/
вообщем поправил

@T0mbery T0mbery force-pushed the remove_store_method_for_rest_group branch 4 times, most recently from 66b7293 to 451025f Compare September 30, 2022 16:15
@T0mbery T0mbery force-pushed the remove_delete_method_for_file branch 2 times, most recently from c66a988 to 6843eea Compare September 30, 2022 16:55
@T0mbery T0mbery force-pushed the remove_store_method_for_rest_group branch from 451025f to 8e6372b Compare September 30, 2022 17:41
@T0mbery T0mbery force-pushed the remove_delete_method_for_file branch from 6843eea to b51816d Compare September 30, 2022 17:42
@T0mbery T0mbery force-pushed the remove_store_method_for_rest_group branch from 449d89e to 6aee5fa Compare October 2, 2022 09:59
@T0mbery T0mbery force-pushed the remove_delete_method_for_file branch 2 times, most recently from 3e27f3f to bd5f32e Compare October 2, 2022 10:14
@T0mbery T0mbery force-pushed the remove_store_method_for_rest_group branch from 17f8680 to 08350e4 Compare October 6, 2022 13:10
@T0mbery T0mbery force-pushed the remove_delete_method_for_file branch from bd5f32e to 6818a7d Compare October 6, 2022 13:12
@T0mbery T0mbery merged commit eed8a5b into remove_store_method_for_rest_group Oct 7, 2022
@rsedykh rsedykh deleted the remove_delete_method_for_file branch November 28, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants