Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump faraday versions #64

Closed
wants to merge 1 commit into from
Closed

Conversation

Draiken
Copy link

@Draiken Draiken commented Oct 22, 2020

Description

The current Faraday dependency is extremely old (8 years ago) and very restrictive.

I've relaxed the version requirements and ran the tests without issues.

Version 3 is still in development and unfortunately forcing anyone that uses the gem to downgrade Faraday to 0.9 is not a great solution. Because of that I believe we can relax those dependencies without issues.

Changelog Stub

  • Relaxed faraday and faraday-middleware dependency versions

Checklist

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 99.507% when pulling 1e92df1 on Draiken:bump-faraday into f78e510 on uploadcare:master.

@Draiken
Copy link
Author

Draiken commented Oct 23, 2020

Crap, I think to support Ruby 1.9 we'd also have to lock json version to ~> 1 and that'd use a very vulnerable JSON version from 2015 too.
And you cannot really release a minor patch changing these versions without breaking apps on Ruby 1.9. I imagine it'd have to be a major version upgrade.

I guess I will have to use a fork until version 3 is out 😞

@Draiken Draiken closed this Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants