Disable camera for not HTTPS #306 #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the localization strings added only for English and Russian languages. |
| @@ -74,6 +74,9 @@ uploadcare.namespace 'locale.translations', (ns) -> | |||
| notFound: | |||
| title: 'No camera detected' | |||
| text: 'Looks like you have no camera connected to this device.' | |||
| notHttps: | |||
| title: 'Camera does not allowed for not protected connections' | |||
ZNick1982
changed the title
|
There are should be two separate pull-requests for Camera and intialization errors. |
|
Ok, I`ll fix it tonight |
|
The main Idea was to disable camera source at all. I.e. to hide entire tab, not to show error message to the user. Sorry for not make it clear. Error message is meaningless for end-user, because he can't do anything with this. Site developer should see the message and decide to exclude the camera tab or to switch to the HTTPS. |
|
Maybe almost all code should be in |
ZNick1982
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done with task.
Added check for chrome and for http connection according task
Spent 3 hours