Skip to content

Commit

Permalink
Change local development docker container name to prevent issues with…
Browse files Browse the repository at this point in the history
… services of the same name started
  • Loading branch information
Roussetos Karafyllakis committed May 13, 2024
1 parent 484f42d commit 2ccddb9
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 12 deletions.
12 changes: 6 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@ setup-php83: stop-containers --prep-dockerfile-php83 start-containers --remove-p

# Get a shell on the PHP container
shell:
docker compose exec -it app /bin/bash
docker compose exec -it provision-provider-seo /bin/bash

# Run Static Analysis (PHPStan)
static-analysis:
docker compose exec app ./vendor/bin/phpstan analyse --memory-limit=1G
docker compose exec provision-provider-seo ./vendor/bin/phpstan analyse --memory-limit=1G

coding-standards:
docker compose exec app php ./bin/php-cs-fixer-v3.phar fix --config=./.php-cs-fixer.dist.php
docker compose exec provision-provider-seo php ./bin/php-cs-fixer-v3.phar fix --config=./.php-cs-fixer.dist.php

# Start the dev environment
start-containers:
Expand All @@ -50,7 +50,7 @@ kill-containers:

# Install composer dependencies
composer-install:
docker compose exec app composer install --no-interaction
docker compose exec provision-provider-seo composer install --no-interaction

# Copy Dockerfile for PHP 8.1
--prep-dockerfile-php81: --remove-dockerfile --prep-docker-compose-file
Expand All @@ -77,8 +77,8 @@ composer-install:

# Remove composer.lock file
--remove-lockfile:
docker compose exec app rm -f ./composer.lock
docker compose exec provision-provider-seo rm -f ./composer.lock

# Remove vendor directory
--remove-vendor:
docker compose exec app rm -rf ./vendor
docker compose exec provision-provider-seo rm -rf ./vendor
11 changes: 5 additions & 6 deletions docker-compose.yml.example
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,22 @@ version: '3.3'
services:

#PHP Service
app:
provision-provider-seo:
build:
context: .
dockerfile: ./.docker/Dockerfile
container_name: app
restart: unless-stopped
container_name: provision-provider-seo
tty: true
environment:
SERVICE_NAME: app
SERVICE_NAME: provision-provider-seo
SERVICE_TAGS: dev
working_dir: /usr/src/lib
volumes:
- ./:/usr/src/lib
networks:
- app-network
- provision-provider-seo-network

#Docker Networks
networks:
app-network:
provision-provider-seo-network:
driver: bridge

0 comments on commit 2ccddb9

Please sign in to comment.