Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WHMv1] Attempt to recover from createacct, suspendreseller & unsuspendreseller request timeouts #11

Closed
uphlewis opened this issue Aug 25, 2022 · 0 comments · Fixed by #12

Comments

@uphlewis
Copy link
Contributor

In certain setups there are WHM function hook scripts which may take a long time to run (esp. for reseller suspensions/unsuspensions where they have a lot of subaccounts), which stalls the API response, leading to a timeout. Timeouts mean we return a false negative on provision function success which leads to extra work from org admins.

We may be able to add some clever handling when we encounter a timeout after these API calls, to check whether the operation appears to have succeeded and is just still in progress.

uphlewis added a commit that referenced this issue Aug 25, 2022
- After a createacct timeout, attempt to load account info and return
  success (indicating account creation still in progress)
- After a suspendreseller timeout, if account is suspended return success
- After an unsuspendreseller timeout, if account is not suspended return
  success
uphlewis added a commit that referenced this issue Aug 25, 2022
uphlewis added a commit that referenced this issue Aug 25, 2022
uphlewis added a commit that referenced this issue Aug 25, 2022
- Use client with http_errors enabled
- Treat HTTP 524 errors like regular request timeouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant