Support multiple type of root view controllers for content action #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind to update pull request so I could merge it ? |
|
yes, found another issue as well with resizing when orientation is changed so I will work that out as well. |
centered the content view close button properly sized the web content view based on the currently displayed view size/orientation updated the topViewController logic to work properly when a modal view is the top most view controller
| @@ -96,14 +96,29 @@ - (BOOL)canPerformBeaconAction:(BLETrigger *)trigger forState:(BLEActionState)st | |||
|
|
|||
| #pragma mark - Private | |||
|
|
|||
| + (UIViewController *)visibleViewControllerFrom:(UIViewController *) vc { | |||
| if ([vc isKindOfClass:[UINavigationController class]]) { | |||
| return [BLEContentAction visibleViewControllerFrom:[((UINavigationController *) vc) visibleViewController]]; | |||
There was a problem hiding this comment.
that about topViewController here ?
|
merge but this minor issue with topViewController is still valid to change. |
krzyzanowskim
pushed a commit
that referenced
this pull request
May 13, 2014
Support multiple type of root view controllers for content action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the methodology to find the top view controller to support multiple types of root view controllers