Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify sig nonce #12

Merged
merged 2 commits into from Sep 20, 2018
Merged

modify sig nonce #12

merged 2 commits into from Sep 20, 2018

Conversation

piouslove
Copy link
Contributor

the key of sig nonce should be identity owner not identity

@mi-xu mi-xu requested a review from pelle September 19, 2018 21:13
@mi-xu
Copy link
Contributor

mi-xu commented Sep 19, 2018

Proposed fix seems right. Looks like the same issue happens in setAttributeSigned() on line 112 and revokeAttributeSigned() on line 126.

@piouslove
Copy link
Contributor Author

I corrected the same issue happens in setAttributeSigned() on line 112 and revokeAttributeSigned() on line 126. This looks better.

@mi-xu mi-xu self-requested a review September 20, 2018 19:22
Copy link
Contributor

@mi-xu mi-xu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mi-xu mi-xu merged commit f4e17ee into uport-project:develop Sep 20, 2018
@nichonien nichonien mentioned this pull request Nov 29, 2021
@mirceanis mirceanis mentioned this pull request Jul 7, 2022
mirceanis added a commit that referenced this pull request Jul 7, 2022
chore:new release

BREAKING CHANGE: Please see #12 and #52

In #12: The nonce calculation for *Signed() methods now uses the identity owner, not the identity.
In #52 The npm output files now include a deployments array along with the contract build output.
uport-automation-bot pushed a commit that referenced this pull request Jul 7, 2022
# [1.0.0](v0.0.3...1.0.0) (2022-07-07)

### Bug Fixes

* update compiler version and remove deprecated entities ([#45](#45)) ([c906383](c906383))

* Merge pull request #53 from uport-project/develop ([210e1a5](210e1a5)), closes [#53](#53) [#12](#12) [#52](#52)

### Features

* add deployments JSON and use an index for the module ([ae9f393](ae9f393))
* adopt hardhat for development ([#46](#46)) ([0ab4f15](0ab4f15))

### BREAKING CHANGES

* Please see #12 and #52
uport-automation-bot pushed a commit that referenced this pull request Jul 7, 2022
# [1.0.0](v0.0.3...1.0.0) (2022-07-07)

### Bug Fixes

* update compiler version and remove deprecated entities ([#45](#45)) ([c906383](c906383))

* Merge pull request #53 from uport-project/develop ([210e1a5](210e1a5)), closes [#53](#53) [#12](#12) [#52](#52)

### Features

* add deployments JSON and use an index for the module ([ae9f393](ae9f393))
* adopt hardhat for development ([#46](#46)) ([0ab4f15](0ab4f15))

### BREAKING CHANGES

* Please see #12 and #52
@uport-automation-bot
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants