Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove deprecated modules #46

Merged
merged 7 commits into from
Mar 21, 2020

Conversation

mirceanis
Copy link
Contributor

Removed the following deprecated items:

  • uport-did
  • UniversalDID singleton
  • EthrDIDResolver legacy constructor
  • legacy JWTTools.verify method

in preparation for the next major release.

If you're using any of those, the latest release that has them is 0.3.6

@mirceanis mirceanis added this to the 0.4.x milestone Mar 21, 2020
@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #46 into develop will increase coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #46      +/-   ##
=============================================
+ Coverage      72.91%   72.97%   +0.06%     
+ Complexity       216      172      -44     
=============================================
  Files             32       27       -5     
  Lines           1030      877     -153     
  Branches         159      138      -21     
=============================================
- Hits             751      640     -111     
+ Misses           188      159      -29     
+ Partials          91       78      -13
Impacted Files Coverage Δ Complexity Δ
jwt/src/main/java/me/uport/sdk/jwt/ECUtils.kt 74.41% <ø> (ø) 0 <0> (ø) ⬇️
.../uport/credentialstatus/UniversalStatusResolver.kt 72.72% <ø> (ø) 5 <0> (ø) ⬇️
...n/java/me/uport/credentialstatus/StatusResolver.kt 100% <ø> (ø) 0 <0> (ø) ⬇️
...main/java/me/uport/sdk/universaldid/DIDDocument.kt 64.28% <ø> (-2.39%) 0 <0> (ø)
.../main/java/me/uport/sdk/ethrdid/EthrDIDDocument.kt 60% <ø> (ø) 8 <0> (ø) ⬇️
jwt/src/main/java/me/uport/sdk/jwt/JWTTools.kt 84.86% <ø> (-1.59%) 49 <0> (-8)
...java/me/uport/sdk/ethrstatus/EthrStatusResolver.kt 89.47% <ø> (ø) 11 <0> (ø) ⬇️
.../main/java/me/uport/sdk/ethrdid/Erc1056Contract.kt 52% <0%> (ø) 0 <0> (?)
...java/me/uport/sdk/ethrstatus/RevocationContract.kt 16.66% <0%> (ø) 0 <0> (ø) ⬇️
.../src/main/java/me/uport/sdk/jwt/model/JwtHeader.kt 66.66% <100%> (ø) 6 <1> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37e7b76...a980351. Read the comment docs.

@mirceanis mirceanis merged commit 208d9f1 into develop Mar 21, 2020
@mirceanis mirceanis deleted the refactor/remove-deprecated-modules branch March 21, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant