This repository has been archived by the owner on May 10, 2021. It is now read-only.
Feat/update eip712 #227
Merged
Feat/update eip712 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## develop #227 +/- ##
========================================
Coverage 89.12% 89.12%
========================================
Files 2 2
Lines 239 239
========================================
Hits 213 213
Misses 26 26
Continue to review full report at Codecov.
|
rmw2
added a commit
that referenced
this pull request
Dec 18, 2018
* feat: add support for simple self-signed app profiles hosted on IPFS * feat: add support for issc field in requests and on connect obj * test: add coverage for issc/profiles * feat: self-sign and upload profile claim to ipfs on construction * fix: small typo in requestVerificationSignature, formatting changes * fix: update credentials methods in tests, update credentials dep also fix vc being passed in unsignedClaim rather than as an additional option. * feat: move ipfs upload out of constructor * test: create tests for ipfs upload, fix old tests to avoid upload * fix: update profile property names to match spec * chore: update package-lock and remove yarn.lock * chore: update circle.yml to use npm * feat: add profileImage, bannerImage and restructure profile claim * test: fix uport-credentials dep to #develop to fix tests * chore: update dependency on uport-credentials * feat: use universal links on first request, deep links after (#214) * chore: update .babelrc to use preset-env and transform-runtime * 1.1.0-alpha-3 * feat: use universal links on first request, deep links after * test: add tests for mobileTransport and URI schemes * chore: bump version in uport-transports * feat: add support for eip 712 sig request in Connect and Subprovider (#212) * feat: add support for signTypedData request in subprovider and connect * test: fix dependencies and add tests for eth_signTypedData * chore: bump dependency on uport-transports * test: add test for wrapped subprovider call in connect * fix: destructure profile claim (#219) * Fix profile claim * Fix profile test * Fix `sub` of profile jwt (#220) * fix: use this.keypair.did for profile subject * 1.1.0-alpha.5 * Revise Headings/ Move tutorial.md (#222) * Revise Headings I've made some adjustments to the headings to improve navigation through this document. I also made a few minor changes here and there. * Create readme This document was originally under guides as a tutorial, but it fits better here. * Delete Tutorial.md This file has been renamed to readme.md and moved to the example-tutorials folder. * Update readme.md A few minor changes: * Heading capitalization * Fixing a broken link * Removing unnecessary content * fix: remove dead link in README (#226) point to developer site instead. resolves #188 also change `requestDisclosure({})` to `requestDisclosure()` * Feat/update eip712 (#227) * chore: bump uport-transports to 0.1.0 * feat: replace aud with did, callbackUrl with callback * Feat/update transports (#229) * chore: bump transports * 1.1.0-alpha.8 * chore: bump transports to 0.2.0-alpha.4, fix chasqui parsing * 1.1.0-alpha.9 * Adding protocol to profile url (#234) Looks good * feat: add support for personal sign in Connect and Subprovider (#230) * bump to 1.1.0-alpha.13 and update credentials/transports (#235) * Remove usage guide from ToC * Update issue templates (#248) * Int/shim pubsub (#254) * Shim the loading of pubsub-js, to not use define as a function (#252) Looks good, thanks for the contribution! Moving to an integration branch on this repo, and will go to develop from there * chore: use carrot dependencies * chore: bump credentials and transports to rc.0 * 1.1.0-rc.0 * do not convert message data type (#253) ignoring warning for coverage reduction by 0.09% * 1.1.0-rc.1 * feat: encode signatures as single hex string in subprovider * 1.1.0-rc.2 * fix: prefix signature with 0x * fix: prefix signature with 0x * fix: use from: address instead of riss: did in web3 sig reqs * chore: bump lib dependencies * 1.1.0-rc.4 * feat: add net param to web3 sig reqs * 1.1.0-rc.5 * doc: update release notes * 1.1.0
rmw2
added a commit
that referenced
this pull request
Jan 31, 2019
* feat: add support for simple self-signed app profiles hosted on IPFS * feat: add support for issc field in requests and on connect obj * test: add coverage for issc/profiles * feat: self-sign and upload profile claim to ipfs on construction * fix: small typo in requestVerificationSignature, formatting changes * fix: update credentials methods in tests, update credentials dep also fix vc being passed in unsignedClaim rather than as an additional option. * feat: move ipfs upload out of constructor * test: create tests for ipfs upload, fix old tests to avoid upload * fix: update profile property names to match spec * chore: update package-lock and remove yarn.lock * chore: update circle.yml to use npm * feat: add profileImage, bannerImage and restructure profile claim * test: fix uport-credentials dep to #develop to fix tests * chore: update dependency on uport-credentials * feat: use universal links on first request, deep links after (#214) * chore: update .babelrc to use preset-env and transform-runtime * 1.1.0-alpha-3 * feat: use universal links on first request, deep links after * test: add tests for mobileTransport and URI schemes * chore: bump version in uport-transports * feat: add support for eip 712 sig request in Connect and Subprovider (#212) * feat: add support for signTypedData request in subprovider and connect * test: fix dependencies and add tests for eth_signTypedData * chore: bump dependency on uport-transports * test: add test for wrapped subprovider call in connect * fix: destructure profile claim (#219) * Fix profile claim * Fix profile test * Fix `sub` of profile jwt (#220) * fix: use this.keypair.did for profile subject * 1.1.0-alpha.5 * Revise Headings/ Move tutorial.md (#222) * Revise Headings I've made some adjustments to the headings to improve navigation through this document. I also made a few minor changes here and there. * Create readme This document was originally under guides as a tutorial, but it fits better here. * Delete Tutorial.md This file has been renamed to readme.md and moved to the example-tutorials folder. * Update readme.md A few minor changes: * Heading capitalization * Fixing a broken link * Removing unnecessary content * fix: remove dead link in README (#226) point to developer site instead. resolves #188 also change `requestDisclosure({})` to `requestDisclosure()` * Feat/update eip712 (#227) * chore: bump uport-transports to 0.1.0 * feat: replace aud with did, callbackUrl with callback * Feat/update transports (#229) * chore: bump transports * 1.1.0-alpha.8 * chore: bump transports to 0.2.0-alpha.4, fix chasqui parsing * 1.1.0-alpha.9 * Adding protocol to profile url (#234) Looks good * feat: add support for personal sign in Connect and Subprovider (#230) * bump to 1.1.0-alpha.13 and update credentials/transports (#235) * Remove usage guide from ToC * Update issue templates (#248) * Int/shim pubsub (#254) * Shim the loading of pubsub-js, to not use define as a function (#252) Looks good, thanks for the contribution! Moving to an integration branch on this repo, and will go to develop from there * chore: use carrot dependencies * do not convert message data type (#253) ignoring warning for coverage reduction by 0.09% * Better Private Chain support (#257) * Better Private Chain support * fix: add rpcUrl to tx, don't allow id override * Support injected providers in UportSubprovider (#231) * feat: add support for injected providers * feat: add inject-loader and tests for using askProvider * feat: add support for injected providers * feat: add inject-loader and tests for using askProvider * refac: move common utility functions out to ./util.js * feat: don't show injected provider dialog on mobile, remember choices * feat: bump to compatible transports * fix: update deep link handling * fix: resolved broken tests after merge * 1.1.2-rc.0
rmw2
added a commit
that referenced
this pull request
Feb 7, 2019
* feat: use universal links on first request, deep links after * test: add tests for mobileTransport and URI schemes * chore: bump version in uport-transports * 1.0.0-alpha-6 * Fix dependency in web3 example (#221) * 1.0.0-alpha-6 * chore: update dependency on uport-connect to '../../' * feat: switch back to deep links only, preserve support for switching * 1.0.0-beta.1 * 1.0.0 * test: increase coverage of less important cases to please CI * chore: bump transports to include uri fix (#233) * feat: allow verification sig req to specify exp (#237) * feat: allow verification sig req to specify exp * doc: update jsdoc for opts params, throw error if sub is missing * chore: bump to latest uport-credentials * test: add coverage for missing sub case * v1.0.2 * Release/v1.1.0 (#255) * feat: add support for simple self-signed app profiles hosted on IPFS * feat: add support for issc field in requests and on connect obj * test: add coverage for issc/profiles * feat: self-sign and upload profile claim to ipfs on construction * fix: small typo in requestVerificationSignature, formatting changes * fix: update credentials methods in tests, update credentials dep also fix vc being passed in unsignedClaim rather than as an additional option. * feat: move ipfs upload out of constructor * test: create tests for ipfs upload, fix old tests to avoid upload * fix: update profile property names to match spec * chore: update package-lock and remove yarn.lock * chore: update circle.yml to use npm * feat: add profileImage, bannerImage and restructure profile claim * test: fix uport-credentials dep to #develop to fix tests * chore: update dependency on uport-credentials * feat: use universal links on first request, deep links after (#214) * chore: update .babelrc to use preset-env and transform-runtime * 1.1.0-alpha-3 * feat: use universal links on first request, deep links after * test: add tests for mobileTransport and URI schemes * chore: bump version in uport-transports * feat: add support for eip 712 sig request in Connect and Subprovider (#212) * feat: add support for signTypedData request in subprovider and connect * test: fix dependencies and add tests for eth_signTypedData * chore: bump dependency on uport-transports * test: add test for wrapped subprovider call in connect * fix: destructure profile claim (#219) * Fix profile claim * Fix profile test * Fix `sub` of profile jwt (#220) * fix: use this.keypair.did for profile subject * 1.1.0-alpha.5 * Revise Headings/ Move tutorial.md (#222) * Revise Headings I've made some adjustments to the headings to improve navigation through this document. I also made a few minor changes here and there. * Create readme This document was originally under guides as a tutorial, but it fits better here. * Delete Tutorial.md This file has been renamed to readme.md and moved to the example-tutorials folder. * Update readme.md A few minor changes: * Heading capitalization * Fixing a broken link * Removing unnecessary content * fix: remove dead link in README (#226) point to developer site instead. resolves #188 also change `requestDisclosure({})` to `requestDisclosure()` * Feat/update eip712 (#227) * chore: bump uport-transports to 0.1.0 * feat: replace aud with did, callbackUrl with callback * Feat/update transports (#229) * chore: bump transports * 1.1.0-alpha.8 * chore: bump transports to 0.2.0-alpha.4, fix chasqui parsing * 1.1.0-alpha.9 * Adding protocol to profile url (#234) Looks good * feat: add support for personal sign in Connect and Subprovider (#230) * bump to 1.1.0-alpha.13 and update credentials/transports (#235) * Remove usage guide from ToC * Update issue templates (#248) * Int/shim pubsub (#254) * Shim the loading of pubsub-js, to not use define as a function (#252) Looks good, thanks for the contribution! Moving to an integration branch on this repo, and will go to develop from there * chore: use carrot dependencies * chore: bump credentials and transports to rc.0 * 1.1.0-rc.0 * do not convert message data type (#253) ignoring warning for coverage reduction by 0.09% * 1.1.0-rc.1 * feat: encode signatures as single hex string in subprovider * 1.1.0-rc.2 * fix: prefix signature with 0x * fix: prefix signature with 0x * fix: use from: address instead of riss: did in web3 sig reqs * chore: bump lib dependencies * 1.1.0-rc.4 * feat: add net param to web3 sig reqs * 1.1.0-rc.5 * doc: update release notes * 1.1.0 * fix: update deep link handling * fix: resolved broken tests after merge * 1.1.2-rc.0 * fix: style and remove extra console logs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
Connect.requestSignTypedDatto match uport-project/specs#38