Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Implemented verifiable credentials specs #116

Merged
merged 16 commits into from Apr 17, 2019

Conversation

pelle
Copy link
Contributor

@pelle pelle commented Apr 13, 2019

See spec

  • Parse request
  • Return requested attestations per spec
  • Separate "Profile Claims" from "Verifiable Credentials" in request card
  • Tap Verifiable Credentials to view Credential in detail
  • Fix display of issuer on Request Card
  • Show missing Verifiable Credentials with instructions on how to receive them
  • Disallow submitting disclosure response if missing essential verifiable claims are present
  • Improve handling of attestations incorrectly issued with milliseconds (Sobol bug)

All required credentials:
image

Missing Essential Verifiable Credentials:
image

Missing Non-Essential Verifiable Credentials:
image

@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #116 into develop will increase coverage by 0.1%.
The diff coverage is 81.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #116     +/-   ##
==========================================
+ Coverage    54.26%   54.36%   +0.1%     
==========================================
  Files          274      274             
  Lines         9189     9190      +1     
  Branches      1873     1882      +9     
==========================================
+ Hits          4986     4996     +10     
+ Misses        3734     3730      -4     
+ Partials       469      464      -5
Impacted Files Coverage Δ
lib/sagas/requests/addAttestations.js 91.3% <ø> (-0.37%) ⬇️
lib/components/Request/types/Eip712SignCard.js 11.11% <ø> (+0.24%) ⬆️
lib/reducers/uportReducer.js 98.05% <ø> (-0.14%) ⬇️
lib/constants/UportActionTypes.js 100% <ø> (ø) ⬆️
...b/components/Verifications/VerificationListItem.js 0% <ø> (ø) ⬆️
lib/components/Request/types/PersonalSignCard.js 11.36% <ø> (+0.25%) ⬆️
...b/components/Request/types/VerificationSignCard.js 11.11% <ø> (+0.24%) ⬆️
lib/sagas/startupSaga.js 0% <ø> (ø) ⬆️
lib/actions/uportActions.js 100% <ø> (ø) ⬆️
lib/screens/Credentials.js 0% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a997d...d8a3a47. Read the comment docs.

@pelle pelle force-pushed the feature/#165330700/claim-specs branch from aebfc65 to b433062 Compare April 15, 2019 18:48
Copy link
Member

@simonas-notcat simonas-notcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting duplicate entries in Profile and Verifiable claims:
IMG_3697

@simonas-notcat simonas-notcat merged commit 55aae73 into develop Apr 17, 2019
@mirceanis mirceanis deleted the feature/#165330700/claim-specs branch January 22, 2020 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants