fix: Allow empty issuers in sdr credential request

decentralized-identity · Oct 1, 2020 · 453a51c · 453a51c
1 parent 3414781
commit 453a51c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/__tests__/shared/handleSdrMessage.ts b/__tests__/shared/handleSdrMessage.ts
@@ -91,6 +91,21 @@ export default (testContext: {
       expect(verifiableCredential.proof.jwt).toBeDefined()
     })
 
+    it('should accept empty issuers array', async () => {
+      const credentials = await agent.getVerifiableCredentialsForSdr({
+        sdr: {
+          claims: [
+            {
+              claimType: 'name',
+              issuers: [],
+            },
+          ],
+        },
+      })
+
+      expect(credentials[0].credentials[0]).toHaveProperty('proof.jwt')
+    })
+
     it('should create verifiable presentation', async () => {
       const credentials = await agent.getVerifiableCredentialsForSdr({
         sdr: {

diff --git a/packages/daf-selective-disclosure/src/action-handler.ts b/packages/daf-selective-disclosure/src/action-handler.ts
@@ -99,7 +99,7 @@ export class SelectiveDisclosure implements IAgentPlugin {
         findArgs.where?.push({ column: 'value', value: [credentialRequest.claimValue] })
       }
 
-      if (credentialRequest.issuers) {
+      if (credentialRequest.issuers && credentialRequest.issuers.length > 0) {
         findArgs.where?.push({ column: 'issuer', value: credentialRequest.issuers.map((i) => i.did) })
       }