Import DID support for daf-react-native-libsodium #257
Conversation
There was a problem hiding this comment.
Thank you for the initiative to contribute.
I'll mark this as a work in progress. Please signal when it's ready for review.
We are getting closer to releasing version 7 which has some significant changes that may lead to conflicts. For this reason, it might be better if you base your changes off of the beta branch. That way, they will be easier to incorporate into the codebase.
| @@ -98,4 +98,9 @@ export class KeyManagementSystem extends AbstractKeyManagementSystem { | |||
| debug('Deleting', kid) | |||
| return await this.keyStore.delete(kid) | |||
| } | |||
|
|
|||
| async importKey(serializedKey: SerializedKey) { | |||
| await this.keyStore.set(serializedKey.kid, serializedKey) | |||
There was a problem hiding this comment.
There should be some checks regarding the key capabilities.
Either here, or maybe at the keyStore level.
For example, if a SerializedKey is provided without a privateKeyHex component then it will be unusable after import.
Depending on the keyStore or the type of key other checks may be needed.
There was a problem hiding this comment.
Hi @mirceanis ,
This fix is for daf-react-native-libsodium version 6 where the corresponding daf-libsodium version 6 has the import function implemented in the exact fashion without any checks.
A code changes corresponds to version 7 can have a different PR.
Do you still think that those check should be added ? Pls suggest
Thanks
There was a problem hiding this comment.
ok, so this is not work in progress actually. It makes sense as a fix to daf v6.
I will be merging a bunch of PRs and it will be included in a next hotfix release for daf.
#228
Feature branch to support import Identity for daf-react-native-libsodium package