Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug that prevented react-app from working. #258

Merged
merged 4 commits into from
Nov 10, 2020
Merged

Fix a bug that prevented react-app from working. #258

merged 4 commits into from
Nov 10, 2020
+279 −97

Conversation

winor30
Copy link
Contributor

@winor30 winor30 commented Nov 10, 2020

Problem

daf/examples/react-app cannot work due to type error and CORS's error

Solution

@winor30
fix: Update web-did-resolver version
84bf0dd 
because the lib has bug in previeous version
@winor30
fix: Type error for getIdentityProviders
077580a
@winor30
chore: Update lock
bc2aac2
@winor30
fix: Change initial did of receiver
8612b17 
because we cannot fetch did data from did:web:uport.me
mirceanis
mirceanis approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@mirceanis mirceanis merged commit 9f7dac4 into decentralized-identity:master Nov 10, 2020
@winor30 winor30 deleted the fix/bug-react-app-example branch November 10, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@winor30 @mirceanis