Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessageHandler Unhandled error #294

Closed
simonas-notcat opened this issue Dec 10, 2020 · 1 comment
Closed

MessageHandler Unhandled error #294

simonas-notcat opened this issue Dec 10, 2020 · 1 comment
Assignees
@mirceanis
Labels
bug Something isn't working
Milestone
DAF 7.0

Comments

@simonas-notcat
Copy link
Contributor

Bug severity
5

Describe the bug
When calling agent.handleMessage with some random data I expect to get Unsupported message type error, but instead, I'm getting

UnhandledPromiseRejectionWarning: Error [ERR_UNHANDLED_ERROR]: Unhandled error. ('Unsupported message type')
    at EventEmitter.emit (events.js:199:17)

To Reproduce
Steps to reproduce the behaviour:

  1. daf msg --save false -r hello

Expected behaviour
Should throw Unsupported message type error

Versions:

  • Daf: 7.0.0-beta.56
  • Node Version v12.13.1
@simonas-notcat simonas-notcat added the bug Something isn't working label Dec 10, 2020
@simonas-notcat simonas-notcat added this to the DAF 7.0 milestone Dec 10, 2020
mirceanis added a commit that referenced this issue Dec 14, 2020
@mirceanis
fix(message-handler): Rewire promise rejections as Error objects and
04310ac 
fixes #294
mirceanis added a commit that referenced this issue Dec 14, 2020
@mirceanis
fix(message-handler): Rewire promise rejections as Error objects and
c7f932c 
fixes #294
@mirceanis mirceanis mentioned this issue Dec 14, 2020
Merged
mirceanis added a commit that referenced this issue Dec 14, 2020
@mirceanis
fix(message-handler): Rewire promise rejections as Error objects (#300
04446d4 
)

fixes #294
@mirceanis
Copy link
Member

fixed in #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirceanis mirceanis

Labels
bug Something isn't working
Projects
None yet
Milestone
DAF 7.0
Development

No branches or pull requests
2 participants
@mirceanis @simonas-notcat