Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

did:ethr provider addKey with X25519 key type does not add keyAgreement section to DID doc #743

Closed
mirceanis opened this issue Nov 10, 2021 · 0 comments · Fixed by #744
Closed

did:ethr provider addKey with X25519 key type does not add keyAgreement section to DID doc #743

mirceanis opened this issue Nov 10, 2021 · 0 comments · Fixed by #744
Labels
bug Something isn't working

Comments

@mirceanis
Copy link
Member

Bug severity
2

Describe the bug
When calling didManagerAddKey() for a did:ethr with a key of type X25519, this should then be visible in the keyAgreement section of the DID document.
This behavior is expected by DIDComm.

Additional context
relates to decentralized-identity/ethr-did-resolver#145
@mirceanis mirceanis added the bug Something isn't working label Nov 10, 2021
mirceanis added a commit that referenced this issue Nov 11, 2021
@mirceanis
feat(did-provider-ethr): add X25519 keys to keyAgreement section
dd414b5 
fixes #743
@mirceanis mirceanis mentioned this issue Nov 11, 2021
Merged
mirceanis added a commit that referenced this issue Nov 11, 2021
@mirceanis
feat(did-comm): didcomm messaging using did:ethr (#744)
1be5e04 
* test: fix test async setup

* chore(deps): bump DID dependencies

* feat(did-provider-ethr): add X25519 keys to `keyAgreement` section
  fixes #743

* fix(did-comm): use more specific error messages for keyAgreement

* fix(did-comm): compare compressed keys for secp256k1
  fixes `packDidCommMessage()` using `jws` packing for Secp256k1 keys.

* test(did-comm): cover more corner cases with tests
@mirceanis mirceanis mentioned this issue Nov 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: didcomm messaging using did:ethr decentralized-identity/veramo
1 participant
@mirceanis