Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Relax Coveralls threshhold and suppress Code Climate PR status failures #727

Closed
apetro opened this issue Oct 12, 2017 · 4 comments
Closed

Relax Coveralls threshhold and suppress Code Climate PR status failures #727

apetro opened this issue Oct 12, 2017 · 4 comments

Comments

@apetro
Copy link
Contributor

apetro commented Oct 12, 2017

We should improve test coverage someday.

In the meantime, Coveralls delivering red Xs to pull requests is demoralizing and distracting without being helpful.

Therefore reconfigured Coveralls with cartoonishly low standards about test coverage. Should always pass. We still get the automatic calc, we can choose to engage with test coverage any time we want, but we stop with the annoyance in the meantime.

(Logged as GitHub issue for transparency.)
@ChristianMurphy
Copy link
Contributor

Related to uPortal-Attic/uportal-app-framework#574

@apetro
Copy link
Contributor Author

apetro commented Oct 12, 2017

Ditto Code Climate, done.

@apetro apetro changed the title Relax Coveralls threshold Relax Coveralls threshhold and suppress Code Climate PR status failures Oct 12, 2017
@ChristianMurphy
Copy link
Contributor

done.
#727 (comment)

@apetro does that mean this ticket is complete and can be closed?

@apetro
Copy link
Contributor Author

apetro commented Nov 2, 2017

Think this is done, yes.

@apetro apetro closed this as completed Nov 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apetro @ChristianMurphy