Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionTx is hiding errors by returning rollback result #31

Merged
merged 2 commits into from
Dec 5, 2018
Merged

SessionTx is hiding errors by returning rollback result #31

merged 2 commits into from
Dec 5, 2018

Commits on Dec 5, 2018

  1. SessionTx shouldn't return rollback error/success - it should return … 

    …error that caused the rollback.

Rollback error should only be returned if rollback fails
    @c2h5oh
    c2h5oh committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    21d5ad8 View commit details
    Browse the repository at this point in the history

  2. Return both errors

    @c2h5oh
    c2h5oh committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    54e47d9 View commit details
    Browse the repository at this point in the history