Replace lib/pq with pgx #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think if it’s possible to remove dependency on lib/pq? I noticed here it’s still being used for custom types — https://github.com/upper/db/blob/issue-621_pgx-driver-for-postgresql/adapter/postgresql/custom_types.go#L30 perhaps that is fine though? Or.. should we update the custom type code to use pgx.. it would require a lot of what lib/pq does to move here, I’m not sure it makes a difference .. lmk what you think |
|
@pkieltyka Yes, that's for now because we're using those types for tests, but the goal is to remove all lib/pq dependencies. |
xiam
force-pushed
the
issue-621_pgx-driver-for-postgresql
branch
from
8af4bb1
to
2dac4f3
Compare
…s and tools for JSONB conversion
xiam
force-pushed
the
issue-621_pgx-driver-for-postgresql
branch
from
4ce5abd
to
c165aee
Compare
|
This has been working fine for a while. Let's merge into master, we'll include this on the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the lib/pq driver with the pgx driver. It also changes code around automatic type conversions which was required to facilitate said migration.