Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Template CI build failing #56

Closed
zoebott opened this issue Nov 17, 2020 · 3 comments
Closed

Update Template CI build failing #56

zoebott opened this issue Nov 17, 2020 · 3 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@zoebott
Copy link

zoebott commented Nov 17, 2020

The Update Template CI is failing on the Setup Node.js step during the build.
image

This is due to GitHub deprecating a feature as explained here.

The issue was raised in the Setup Node action - actions/setup-node#212
It has been fixed in the latest version (i.e. v2.1.2)

@AnandChowdhary
Copy link
Member

Hmm, this is a big problem, because even if I push an update with the updated v2.1.2, it won't "update" the template since that CI is not working anymore in all Upptime projects. Let me add the logic to update setup-note to upptime/uptime-monitor to make sure that it's up to date.

AnandChowdhary added a commit to upptime/uptime-monitor that referenced this issue Nov 17, 2020
@AnandChowdhary
Copy link
Member

I've added a fix that replaces actions/setup-node@v2.1.2 with actions/setup-node@v1.4.4 in all workflows (upptime/uptime-monitor@c6f6376). This fix runs when graphs are updated, so it should be run for all Upptime repositories within 24 hours, or if someone manually runs "Graphs CI" or "Setup CI".

@AnandChowdhary AnandChowdhary self-assigned this Nov 17, 2020
@AnandChowdhary AnandChowdhary added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 17, 2020
@zoebott
Copy link
Author

zoebott commented Nov 17, 2020

To add this fix to my repository I had to do the following steps:

  • Change version from actions/setup-node@v2.1.1 to actions/setup-node@v1.4.4 manually in update-template.yml and push to repository
  • Run "Setup CI" workflow
  • Run "Update Template CI" workflow

namcxn pushed a commit to namcxn/uptime-monitor that referenced this issue Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants