Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double percentage sign in alt text of generated README #83

Closed
make-github-pseudonymous-again opened this issue Nov 23, 2020 · 3 comments
Assignees
Labels
bug Something isn't working template Related to the upptime/upptime repository template

Comments

@make-github-pseudonymous-again

See for instance https://github.com/aureooms/monitor/blame/master/README.md#L19. It seems upptime/uptime-monitor#45 would fix this error (I cannot comment there since the conversation is limited to collaborators). I originally thought upptime/uptime-monitor#45 would fix the same kind of bug in the generated PWA, however I was wrong.

@make-github-pseudonymous-again
Copy link
Author

Another solution would be to revert upptime/status-page#64 and merge upptime/uptime-monitor#44.

@AnandChowdhary AnandChowdhary added bug Something isn't working template Related to the upptime/upptime repository template labels Nov 24, 2020
@AnandChowdhary AnandChowdhary self-assigned this Nov 24, 2020
@AnandChowdhary
Copy link
Member

I like the idea of having the formatted percentage (e.g., "92.34%") in the API, otherwise if we store the plain integers, I'd rather we store something like 0.9234 rather than 92.34. Then, the README/status website don't have to do any additional formatting and can use the response as-is. I think I'll just update the README alt text instead. Is that ok?

@make-github-pseudonymous-again
Copy link
Author

I like the idea of having the formatted percentage (e.g., "92.34%") in the API, otherwise if we store the plain integers, I'd rather we store something like 0.9234 rather than 92.34. Then, the README/status website don't have to do any additional formatting and can use the response as-is. I think I'll just update the README alt text instead. Is that ok?

Both "92.34%" and 0.9234 (not rounded?) make sense. The API could also contain both.

namcxn pushed a commit to namcxn/uptime-monitor that referenced this issue Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working template Related to the upptime/upptime repository template
Projects
None yet
Development

No branches or pull requests

2 participants