Add support for multiple NOTIFICATION_TELEGRAM_CHAT_ID #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnandChowdhary
approved these changes
May 4, 2024
|
I think there's something wrong here because there are two variables to deal with, NOTIFICATION_TELEGRAM_BOT_KEY and NOTIFICATION_TELEGRAM_CHAT_ID. Can you please check if we've used the right ones in the logic? |
Resolved, my mistake |
gxres042
commented
May 4, 2024
AnandChowdhary
approved these changes
May 5, 2024
AnandChowdhary
added a commit
that referenced
this pull request
May 5, 2024
|
🎉 This PR is included in version 1.37.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, users can fill in multiple chat ids into NOTIFICATION_TELEGRAM_CHAT_ID like
xxxxx, xxxxx.Feature was requested there: https://github.com/orgs/upptime/discussions/956