Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-emit swim errors #3

Merged
merged 3 commits into from
Oct 9, 2017
Merged

Re-emit swim errors #3

merged 3 commits into from
Oct 9, 2017

Conversation

gillesdemey
Copy link
Contributor

This allows us to listen for errors emitted by the swim library like JoinFailedError, etc.

delvedor
delvedor approved these changes Oct 8, 2017
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Can you also update the documentation?

@gillesdemey
Copy link
Contributor Author

Will get on that :)

@gillesdemey
Copy link
Contributor Author

Done, PTAL 🙏

@mcollina mcollina merged commit d6bf57e into upringjs:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gillesdemey @delvedor @mcollina