Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot save as JPG when using Batch Upscale #174

Closed
krs-n opened this issue Dec 28, 2022 · 18 comments
Closed

Cannot save as JPG when using Batch Upscale #174

krs-n opened this issue Dec 28, 2022 · 18 comments
Labels
bug Something isn't working won't-fix This issue cannot be fixed or will not be fixed from the Upscayl side

Comments

@krs-n
Copy link

krs-n commented Dec 28, 2022

Cannot save as JPG when using Batch Upscale.
PNG output even if JPG is selected in Advanced Options.

@NayamAmarshe
Copy link
Member

NayamAmarshe commented Dec 28, 2022

That's because one of your images is PNG. You can't convert alpha channel in JPG, which is why it outputs PNG.

@krs-n
Copy link
Author

krs-n commented Dec 28, 2022

If I start a batch by specifying a folder that contains only JPGs, I get PNGs.

@aaronliu0130
Copy link
Member

and you selected jpg output?

@NayamAmarshe NayamAmarshe reopened this Dec 28, 2022
@whoiskevinrich
Copy link

Same issue here. All jpeg files are converted to png on batch operations. I did select jpg in the advanced options.

@NayamAmarshe
Copy link
Member

Can someone post the terminal output?

@whoiskevinrich
Copy link

Is there a command-line switch to provide the terminal output? I'm not seeing an obvious option from the GUI

@NayamAmarshe
Copy link
Member

Is there a command-line switch to provide the terminal output? I'm not seeing an obvious option from the GUI

If you launch upscayl using terminal, you'll get the GUI and the console output in the terminal.

@aaronliu0130
Copy link
Member

You may follow these instructions: Download and install git from https://git-scm.com/download/win and node from https://nodejs.org/en/download/current/ (choose standalone installer 64 for both) then run these in your terminal:

git clone https://github.com/TGS963/upscayl
cd upscayl
npm install
npm run start

After the last command, upscayl should show up. Reproduce the error, send a screenshot of the entire window, and send out the terminal output.

@whoiskevinrich
Copy link

whoiskevinrich commented Jan 5, 2023

See attached

[Edit] Ignore the first sample, I forgot to switch the output to JPG, but the second sample is correct.

upscayl-output.txt
upscayl-output2.txt

@NayamAmarshe
Copy link
Member

See attached

[Edit] Ignore the first sample, I forgot to switch the output to JPG, but the second sample is correct.

upscayl-output.txt upscayl-output2.txt

As you can see, upscayl sets -f jpg correctly.

COMMAND: -i D:\Downloads\jpgs -o D:\Downloads\jpgs_upscayled -s 4 -m D:\Source\upscayl\resources\models -n realesrgan-x4plus  -f jpg

If it's still outputting PNGs, I suppose it's the realesrgan binary that's buggy, which we honestly can do nothing about :(

@whoiskevinrich
Copy link

Yes, despite seeing jpg, out still output png

@NayamAmarshe
Copy link
Member

I guess we'll have to mark this as can't fix then.

@NayamAmarshe NayamAmarshe closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2023
@NayamAmarshe NayamAmarshe added the won't-fix This issue cannot be fixed or will not be fixed from the Upscayl side label Jan 5, 2023
@whoiskevinrich
Copy link

whoiskevinrich commented Jan 5, 2023

Could you update the UI to not show the option of output as JPG on batch operations?

@NayamAmarshe
Copy link
Member

Could you update the UI to not show the option of output as JPG on batch operations?

Yes I'll do that

@aaronliu0130
Copy link
Member

#239 reports something interesting:

"General Photo (Ultramix Balanced)", selected "Advanced Options" then "JPG" - all files were converted, BUT with "General Photo (Real-ESRGAN)" and all files were saved as PNG

@Charlie-82
Copy link

Pour moi c'est toujours PNG en sortie :(

@daath
Copy link

daath commented Mar 12, 2023

It's not just the output filetype that is ignored - it's also upscale algorithm. Batch process always uses "General Photo (Real-ESRGAN)" and outputs PNG regardless of what you choose.

@ahsanrbaloch
Copy link

Actually it saves as png only until the whole batch is finished. Once it is finished, then all png images automatically get converted to jpg, and saved as jpg as well. You should wait for the whole batch to complete and then check your results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working won't-fix This issue cannot be fixed or will not be fixed from the Upscayl side
Projects
None yet
Development

No branches or pull requests

7 participants