-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot save as JPG when using Batch Upscale #174
Comments
That's because one of your images is PNG. You can't convert alpha channel in JPG, which is why it outputs PNG. |
If I start a batch by specifying a folder that contains only JPGs, I get PNGs. |
and you selected jpg output? |
Same issue here. All jpeg files are converted to png on batch operations. I did select jpg in the advanced options. |
Can someone post the terminal output? |
Is there a command-line switch to provide the terminal output? I'm not seeing an obvious option from the GUI |
If you launch upscayl using terminal, you'll get the GUI and the console output in the terminal. |
You may follow these instructions: Download and install git from https://git-scm.com/download/win and node from https://nodejs.org/en/download/current/ (choose standalone installer 64 for both) then run these in your terminal: git clone https://github.com/TGS963/upscayl
cd upscayl
npm install
npm run start After the last command, upscayl should show up. Reproduce the error, send a screenshot of the entire window, and send out the terminal output. |
See attached [Edit] Ignore the first sample, I forgot to switch the output to JPG, but the second sample is correct. |
As you can see, upscayl sets
If it's still outputting PNGs, I suppose it's the realesrgan binary that's buggy, which we honestly can do nothing about :( |
Yes, despite seeing jpg, out still output png |
I guess we'll have to mark this as can't fix then. |
Could you update the UI to not show the option of output as JPG on batch operations? |
Yes I'll do that |
#239 reports something interesting:
|
Pour moi c'est toujours PNG en sortie :( |
It's not just the output filetype that is ignored - it's also upscale algorithm. Batch process always uses "General Photo (Real-ESRGAN)" and outputs PNG regardless of what you choose. |
Actually it saves as png only until the whole batch is finished. Once it is finished, then all png images automatically get converted to jpg, and saved as jpg as well. You should wait for the whole batch to complete and then check your results. |
Cannot save as JPG when using Batch Upscale.
PNG output even if JPG is selected in Advanced Options.
The text was updated successfully, but these errors were encountered: