Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images look like a mixed up grid with the scale option #303

Closed
2 tasks done
folkshot opened this issue May 9, 2023 · 19 comments
Closed
2 tasks done

Images look like a mixed up grid with the scale option #303

folkshot opened this issue May 9, 2023 · 19 comments
Labels
bug Something isn't working
Milestone

Comments

@folkshot
Copy link

folkshot commented May 9, 2023

Checklist

  • I have checked that this issue isn't addressed in the FAQ.
  • I have checked that this issue isn't addressed in any other issue or pull request.

Describe the Bug

I select an image to upscayl, select digital art. (this issue happens with both jpg and png). The output image completely scrambles the original image. This just started a few minutes ago after the system forced an update to 2.5.1.

Logs
⚙️ Getting saveImageAs from localStorage png
⚙️ Getting model from localStorage {"label":"Digital Art","value":"realesrgan-x4plus-anime"}
⚙️ Setting gpuId to empty string
🔀 Setting model to 
🔄 Resetting image paths
🔀 Setting model to realesrgan-x4plus-anime
⚙️ Getting saveImageAs from localStorage png
⚙️ Getting model from localStorage {"label":"Digital Art","value":"realesrgan-x4plus-anime"}
⚙️ Setting gpuId to empty string
⚙️ Getting rememberOutputFolder from localStorage false
⚙️ Getting saveImageAs from localStorage png
⚙️ Getting model from localStorage {"label":"Digital Art","value":"realesrgan-x4plus-anime"}
⚙️ Setting gpuId to empty string
🔀 Setting model to 
🔀 Setting model to realesrgan-x4plus-anime
🔄 Resetting image paths
🐞 BACKEND REPORTED:  📄 Selected File Path:  C:\Users\galag\Desktop\AI edit\AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e.png
🖼 Selected Image Path:  C:\Users\galag\Desktop\AI edit\AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e.png
📁 Selected Image Directory:  C:\Users\galag\Desktop\AI edit
🖼 imagePath:  C:\Users\galag\Desktop\AI edit\AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e.png
🔤 Extension:  png
🔄 Resetting Upscaled Image Path
🏁 UPSCAYL
🐞 BACKEND REPORTED:  📢 Upscayl Command:  -i,C:\Users\galag\Desktop\AI edit\AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e.png,-o,C:\Users\galag\Desktop\AI edit\AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e_upscayl_2x_realesrgan-x4plus-anime.png,-s,2,-m,C:\Program Files\Upscayl\resources\models,-n,realesrgan-x4plus-anime,,-f,png
🐞 BACKEND REPORTED:  image upscayl:  [0 NVIDIA GeForce GTX 1060]  queueC=2[8]  queueG=0[16]  queueT=1[2]
[0 NVIDIA GeForce GTX 1060]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[0 NVIDIA GeForce GTX 1060]  fp16-p/s/a=1/1/0  int8-p/s/a=1/1/1
[0 NVIDIA GeForce GTX 1060]  subgroup=32  basic=1  vote=1  ballot=1  shuffle=1

🚧 UPSCAYL_PROGRESS: [0 NVIDIA GeForce GTX 1060] queueC=2[8] queueG=0[16] queueT=1[2]
[0 NVIDIA GeForce GTX 1060] bugsbn1=0 bugbilz=0 bugcopc=0 bugihfa=0
[0 NVIDIA GeForce GTX 1060] fp16-p/s/a=1/1/0 int8-p/s/a=1/1/1
[0 NVIDIA GeForce GTX 1060] subgroup=32 basic=1 vote=1 ballot=1 shuffle=1

🐞 BACKEND REPORTED: image upscayl: [1 Intel(R) UHD Graphics 630] queueC=0[1] queueG=0[1] queueT=0[1]
[1 Intel(R) UHD Graphics 630] bugsbn1=0 bugbilz=0 bugcopc=0 bugihfa=0
[1 Intel(R) UHD Graphics 630] fp16-p/s/a=1/1/0 int8-p/s/a=1/0/0
[1 Intel(R) UHD Graphics 630] subgroup=32 basic=1 vote=1 ballot=1 shuffle=1

🚧 UPSCAYL_PROGRESS: [1 Intel(R) UHD Graphics 630] queueC=0[1] queueG=0[1] queueT=0[1]
[1 Intel(R) UHD Graphics 630] bugsbn1=0 bugbilz=0 bugcopc=0 bugihfa=0
[1 Intel(R) UHD Graphics 630] fp16-p/s/a=1/1/0 int8-p/s/a=1/0/0
[1 Intel(R) UHD Graphics 630] subgroup=32 basic=1 vote=1 ballot=1 shuffle=1

🐞 BACKEND REPORTED: image upscayl: 0.00%

🚧 UPSCAYL_PROGRESS: 0.00%

🐞 BACKEND REPORTED: image upscayl: 2.78%

🚧 UPSCAYL_PROGRESS: 2.78%

🐞 BACKEND REPORTED: image upscayl: 5.56%

🚧 UPSCAYL_PROGRESS: 5.56%

🐞 BACKEND REPORTED: image upscayl: 8.33%

🚧 UPSCAYL_PROGRESS: 8.33%

🐞 BACKEND REPORTED: image upscayl: 11.11%

🚧 UPSCAYL_PROGRESS: 11.11%

🐞 BACKEND REPORTED: image upscayl: 13.89%

🚧 UPSCAYL_PROGRESS: 13.89%

🐞 BACKEND REPORTED: image upscayl: 16.67%

🚧 UPSCAYL_PROGRESS: 16.67%

🐞 BACKEND REPORTED: image upscayl: 19.44%

🚧 UPSCAYL_PROGRESS: 19.44%

🐞 BACKEND REPORTED: image upscayl: 22.22%

🚧 UPSCAYL_PROGRESS: 22.22%

🐞 BACKEND REPORTED: image upscayl: 25.00%

🚧 UPSCAYL_PROGRESS: 25.00%

🐞 BACKEND REPORTED: image upscayl: 27.78%

🚧 UPSCAYL_PROGRESS: 27.78%

🐞 BACKEND REPORTED: image upscayl: 30.56%

🚧 UPSCAYL_PROGRESS: 30.56%

🐞 BACKEND REPORTED: image upscayl: 33.33%

🚧 UPSCAYL_PROGRESS: 33.33%

🐞 BACKEND REPORTED: image upscayl: 36.11%

🚧 UPSCAYL_PROGRESS: 36.11%

🐞 BACKEND REPORTED: image upscayl: 38.89%

🚧 UPSCAYL_PROGRESS: 38.89%

🐞 BACKEND REPORTED: image upscayl: 41.67%

🚧 UPSCAYL_PROGRESS: 41.67%

🐞 BACKEND REPORTED: image upscayl: 44.44%

🚧 UPSCAYL_PROGRESS: 44.44%

🐞 BACKEND REPORTED: image upscayl: 47.22%

🚧 UPSCAYL_PROGRESS: 47.22%

🐞 BACKEND REPORTED: image upscayl: 50.00%

🚧 UPSCAYL_PROGRESS: 50.00%

🐞 BACKEND REPORTED: image upscayl: 52.78%

🚧 UPSCAYL_PROGRESS: 52.78%

🐞 BACKEND REPORTED: image upscayl: 55.56%

🚧 UPSCAYL_PROGRESS: 55.56%

🐞 BACKEND REPORTED: image upscayl: 58.33%

🚧 UPSCAYL_PROGRESS: 58.33%

🐞 BACKEND REPORTED: image upscayl: 61.11%

🚧 UPSCAYL_PROGRESS: 61.11%

🐞 BACKEND REPORTED: image upscayl: 63.89%

🚧 UPSCAYL_PROGRESS: 63.89%

🐞 BACKEND REPORTED: image upscayl: 66.67%

🚧 UPSCAYL_PROGRESS: 66.67%

🐞 BACKEND REPORTED: image upscayl: 69.44%

🚧 UPSCAYL_PROGRESS: 69.44%

🐞 BACKEND REPORTED: image upscayl: 72.22%

🚧 UPSCAYL_PROGRESS: 72.22%

🐞 BACKEND REPORTED: image upscayl: 75.00%

🚧 UPSCAYL_PROGRESS: 75.00%

🐞 BACKEND REPORTED: image upscayl: 77.78%

🚧 UPSCAYL_PROGRESS: 77.78%

🐞 BACKEND REPORTED: image upscayl: 80.56%

🚧 UPSCAYL_PROGRESS: 80.56%

🐞 BACKEND REPORTED: image upscayl: 83.33%

🚧 UPSCAYL_PROGRESS: 83.33%

🐞 BACKEND REPORTED: image upscayl: 86.11%

🚧 UPSCAYL_PROGRESS: 86.11%

🐞 BACKEND REPORTED: image upscayl: 88.89%

🚧 UPSCAYL_PROGRESS: 88.89%

🐞 BACKEND REPORTED: image upscayl: 91.67%

🚧 UPSCAYL_PROGRESS: 91.67%

🐞 BACKEND REPORTED: image upscayl: 94.44%

🚧 UPSCAYL_PROGRESS: 94.44%

🐞 BACKEND REPORTED: image upscayl: 97.22%

🚧 UPSCAYL_PROGRESS: 97.22%

🐞 BACKEND REPORTED: 💯 Done upscaling
upscaledImagePath:
💯 UPSCAYL_DONE: C:\Users\galag\Desktop\AI edit\AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e_upscayl_2x_realesrgan-x4plus-anime.png
⚙️ Getting saveImageAs from localStorage png
⚙️ Getting model from localStorage {"label":"Digital Art","value":"realesrgan-x4plus-anime"}
⚙️ Setting gpuId to empty string
⚙️ Getting rememberOutputFolder from localStorage false
⚙️ Getting saveImageAs from localStorage jpg
⚙️ Getting model from localStorage {"label":"Digital Art","value":"realesrgan-x4plus-anime"}
⚙️ Setting gpuId to empty string
🔀 Setting model to
🔀 Setting model to realesrgan-x4plus-anime
🔄 Resetting image paths
🔄 Resetting image paths
🐞 BACKEND REPORTED: 📄 Selected File Path: C:\Users\galag\Desktop\AI edit\AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e.png
🖼 Selected Image Path: C:\Users\galag\Desktop\AI edit\AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e.png
📁 Selected Image Directory: C:\Users\galag\Desktop\AI edit
🖼 imagePath: C:\Users\galag\Desktop\AI edit\AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e.png
🔤 Extension: png
🔄 Resetting Upscaled Image Path
🏁 UPSCAYL
🐞 BACKEND REPORTED: 📢 Upscayl Command: -i,C:\Users\galag\Desktop\AI edit\AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e.png,-o,C:\Users\galag\Desktop\AI edit\AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e_upscayl_2x_realesrgan-x4plus-anime.jpg,-s,2,-m,C:\Program Files\Upscayl\resources\models,-n,realesrgan-x4plus-anime,,-f,jpg
🐞 BACKEND REPORTED: image upscayl: [0 NVIDIA GeForce GTX 1060] queueC=2[8] queueG=0[16] queueT=1[2]
[0 NVIDIA GeForce GTX 1060] bugsbn1=0 bugbilz=0 bugcopc=0 bugihfa=0
[0 NVIDIA GeForce GTX 1060] fp16-p/s/a=1/1/0 int8-p/s/a=1/1/1
[0 NVIDIA GeForce GTX 1060] subgroup=32 basic=1 vote=1 ballot=1 shuffle=1

🚧 UPSCAYL_PROGRESS: [0 NVIDIA GeForce GTX 1060] queueC=2[8] queueG=0[16] queueT=1[2]
[0 NVIDIA GeForce GTX 1060] bugsbn1=0 bugbilz=0 bugcopc=0 bugihfa=0
[0 NVIDIA GeForce GTX 1060] fp16-p/s/a=1/1/0 int8-p/s/a=1/1/1
[0 NVIDIA GeForce GTX 1060] subgroup=32 basic=1 vote=1 ballot=1 shuffle=1

🐞 BACKEND REPORTED: image upscayl: [1 Intel(R) UHD Graphics 630] queueC=0[1] queueG=0[1] queueT=0[1]
[1 Intel(R) UHD Graphics 630] bugsbn1=0 bugbilz=0 bugcopc=0 bugihfa=0
[1 Intel(R) UHD Graphics 630] fp16-p/s/a=1/1/0 int8-p/s/a=1/0/0
[1 Intel(R) UHD Graphics 630] subgroup=32 basic=1 vote=1 ballot=1 shuffle=1

🚧 UPSCAYL_PROGRESS: [1 Intel(R) UHD Graphics 630] queueC=0[1] queueG=0[1] queueT=0[1]
[1 Intel(R) UHD Graphics 630] bugsbn1=0 bugbilz=0 bugcopc=0 bugihfa=0
[1 Intel(R) UHD Graphics 630] fp16-p/s/a=1/1/0 int8-p/s/a=1/0/0
[1 Intel(R) UHD Graphics 630] subgroup=32 basic=1 vote=1 ballot=1 shuffle=1

🐞 BACKEND REPORTED: image upscayl: 0.00%

🚧 UPSCAYL_PROGRESS: 0.00%

🐞 BACKEND REPORTED: image upscayl: 2.78%

🚧 UPSCAYL_PROGRESS: 2.78%

🐞 BACKEND REPORTED: image upscayl: 5.56%

🚧 UPSCAYL_PROGRESS: 5.56%

🐞 BACKEND REPORTED: image upscayl: 8.33%

🚧 UPSCAYL_PROGRESS: 8.33%

🐞 BACKEND REPORTED: image upscayl: 11.11%

🚧 UPSCAYL_PROGRESS: 11.11%

🐞 BACKEND REPORTED: image upscayl: 13.89%

🚧 UPSCAYL_PROGRESS: 13.89%

🐞 BACKEND REPORTED: image upscayl: 16.67%

🚧 UPSCAYL_PROGRESS: 16.67%

🐞 BACKEND REPORTED: image upscayl: 19.44%

🚧 UPSCAYL_PROGRESS: 19.44%

🐞 BACKEND REPORTED: image upscayl: 22.22%

🚧 UPSCAYL_PROGRESS: 22.22%

🐞 BACKEND REPORTED: image upscayl: 25.00%

🚧 UPSCAYL_PROGRESS: 25.00%

🐞 BACKEND REPORTED: image upscayl: 27.78%

🚧 UPSCAYL_PROGRESS: 27.78%

🐞 BACKEND REPORTED: image upscayl: 30.56%

🚧 UPSCAYL_PROGRESS: 30.56%

🐞 BACKEND REPORTED: image upscayl: 33.33%

🚧 UPSCAYL_PROGRESS: 33.33%

🐞 BACKEND REPORTED: image upscayl: 36.11%

🚧 UPSCAYL_PROGRESS: 36.11%

🐞 BACKEND REPORTED: image upscayl: 38.89%

🚧 UPSCAYL_PROGRESS: 38.89%

🐞 BACKEND REPORTED: image upscayl: 41.67%

🚧 UPSCAYL_PROGRESS: 41.67%

🐞 BACKEND REPORTED: image upscayl: 44.44%

🚧 UPSCAYL_PROGRESS: 44.44%

🐞 BACKEND REPORTED: image upscayl: 47.22%

🚧 UPSCAYL_PROGRESS: 47.22%

🐞 BACKEND REPORTED: image upscayl: 50.00%

🚧 UPSCAYL_PROGRESS: 50.00%

🐞 BACKEND REPORTED: image upscayl: 52.78%

🚧 UPSCAYL_PROGRESS: 52.78%

🐞 BACKEND REPORTED: image upscayl: 55.56%

🚧 UPSCAYL_PROGRESS: 55.56%

🐞 BACKEND REPORTED: image upscayl: 58.33%

🚧 UPSCAYL_PROGRESS: 58.33%

🐞 BACKEND REPORTED: image upscayl: 61.11%

🚧 UPSCAYL_PROGRESS: 61.11%

🐞 BACKEND REPORTED: image upscayl: 63.89%

🚧 UPSCAYL_PROGRESS: 63.89%

🐞 BACKEND REPORTED: image upscayl: 66.67%

🚧 UPSCAYL_PROGRESS: 66.67%

🐞 BACKEND REPORTED: image upscayl: 69.44%

🚧 UPSCAYL_PROGRESS: 69.44%

🐞 BACKEND REPORTED: image upscayl: 72.22%

🚧 UPSCAYL_PROGRESS: 72.22%

🐞 BACKEND REPORTED: image upscayl: 75.00%

🚧 UPSCAYL_PROGRESS: 75.00%

🐞 BACKEND REPORTED: image upscayl: 77.78%

🚧 UPSCAYL_PROGRESS: 77.78%

🐞 BACKEND REPORTED: image upscayl: 80.56%

🚧 UPSCAYL_PROGRESS: 80.56%

🐞 BACKEND REPORTED: image upscayl: 83.33%

🚧 UPSCAYL_PROGRESS: 83.33%

🐞 BACKEND REPORTED: image upscayl: 86.11%

🚧 UPSCAYL_PROGRESS: 86.11%

🐞 BACKEND REPORTED: image upscayl: 88.89%

🚧 UPSCAYL_PROGRESS: 88.89%

🐞 BACKEND REPORTED: image upscayl: 91.67%

🚧 UPSCAYL_PROGRESS: 91.67%

🐞 BACKEND REPORTED: image upscayl: 94.44%

🚧 UPSCAYL_PROGRESS: 94.44%

🐞 BACKEND REPORTED: image upscayl: 97.22%

🚧 UPSCAYL_PROGRESS: 97.22%

🐞 BACKEND REPORTED: 💯 Done upscaling
upscaledImagePath:
💯 UPSCAYL_DONE: C:\Users\galag\Desktop\AI edit\AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e_upscayl_2x_realesrgan-x4plus-anime.jpg
⚙️ Getting saveImageAs from localStorage jpg
⚙️ Getting model from localStorage {"label":"Digital Art","value":"realesrgan-x4plus-anime"}
⚙️ Setting gpuId to empty string
⚙️ Getting rememberOutputFolder from localStorage false

To Reproduce

I select an image to upscayl, select digital art. (this issue happens with both jpg and png). Select the Upscayl button. Wait for it to process. The output image completely scrambles the original image.

Expected Behavior

an upscayl replica of the original image.
AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e
AerodynamicA_vector_style_cartoon_a_large_red_alien_monster_spa_3b74b964-d672-4e17-be06-8ff66f68479e_upscayl_2x_realesrgan-x4plus-anime

Version/Commit Hash

2.5.1

OS Specifics

Win10

Screenshots

image

@folkshot folkshot added the bug Something isn't working label May 9, 2023
@NayamAmarshe
Copy link
Member

Well, that's why the scale option is labeled experimental 😅

This might be of use to you though: https://github.com/upscayl/custom-models

@aaronliu0130
Copy link
Member

I don't think the fact that this is experimental means that this isn't a bug.

@aaronliu0130 aaronliu0130 reopened this May 9, 2023
@NayamAmarshe
Copy link
Member

I don't think the fact that this is experimental means that this isn't a bug.

It's not a bug. The models are made for x4, to use other scales you have to use a compatible model (as mentioned in the custom models repository).

@folkshot
Copy link
Author

folkshot commented May 9, 2023

I thought the 2x scale was what is had been originally. When I placed it back up to the 4x scale, it worked great. Thanks.

@folkshot folkshot closed this as completed May 9, 2023
@aaronliu0130
Copy link
Member

I mean even though the models are made for x4, we should either fix that or use a different way, like downscaling the output

@NayamAmarshe
Copy link
Member

I mean even though the models are made for x4, we should either fix that or use a different way, like downscaling the output

That would be for some future version.

Updated the wiki:
https://github.com/upscayl/upscayl/wiki/Guide#scale-option

@aaronliu0130 aaronliu0130 closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2023
@aaronliu0130
Copy link
Member

Reopening as this is still planned for some future version.

@PhobosK
Copy link

PhobosK commented Jun 4, 2023

Well, that's why the scale option is labeled experimental 😅

This might be of use to you though: https://github.com/upscayl/custom-models

In my 15+ years of experience as a user and as a developer of OSS (with usage even of alfa versions apps), I've never encountered an application where "Experimental" meant a 100% fail result 😄 .... Usually it means -> it may work in certain/most cases but it may not work in others and thus the feature is labeled as "experimental" until all cases are sorted out....

IMHO, in this particular case while this is sorted out in the future version, it would be a good practise the user to be at least warned with some kind of a warning box (if he chooses a 3X, 2X image scale), that he will get a garbage result if the selected "Upscaling type" is not supporting the scale... Sorry but I do not think anyone reads a Wiki that often, maybe until he gets the garbage result..
It will be best of course, if there is an internal check of the supported by the rescale method scales, and when the user selects 3X, the app to list only the supported rescale types...
Anyway there is no way for the user to know by looking to the listed in app scale methods if the method supports the scale or not...

Anyway, thanks for the great work and efforts done with this app guys...
Lovely job

@NayamAmarshe
Copy link
Member

Well, that's why the scale option is labeled experimental 😅

This might be of use to you though: https://github.com/upscayl/custom-models

In my 15+ years of experience as a user and as a developer of OSS (with usage even of alfa versions apps), I've never encountered an application where "Experimental" meant a 100% fail result 😄 .... Usually it means -> it may work in certain/most cases but it may not work in others and thus the feature is labeled as "experimental" until all cases are sorted out....

IMHO, in this particular case while this is sorted out in the future version, it would be a good practise the user to be at least warned with some kind of a warning box (if he chooses a 3X, 2X image scale), that he will get a garbage result if the selected "Upscaling type" is not supporting the scale... Sorry but I do not think anyone reads a Wiki that often, maybe until he gets the garbage result..
It will be best of course, if there is an internal check of the supported by the rescale method scales, and when the user selects 3X, the app to list only the supported rescale types...
Anyway there is no way for the user to know by looking to the listed in app scale methods if the method supports the scale or not...

Anyway, thanks for the great work and efforts done with this app guys...
Lovely job

Experimental label is there because it only works with certain models, not all of them, definitely not the default ones. So it definitely works, just not the way a user would think it should work.

The new version already has warnings and links to wiki, so that's sorted :)

@PhobosK
Copy link

PhobosK commented Jun 4, 2023

That's great !

Thanks a lot :)

Keep up the great work and your great attitude to users ;)

@aaronliu0130 aaronliu0130 changed the title output has my images looking like a mixed up grid Images look like a mixed up grid with the scale option Jun 5, 2023
@deepnx
Copy link

deepnx commented Jun 27, 2023

Well, that's why the scale option is labeled experimental 😅
This might be of use to you though: https://github.com/upscayl/custom-models

In my 15+ years of experience as a user and as a developer of OSS (with usage even of alfa versions apps), I've never encountered an application where "Experimental" meant a 100% fail result 😄 .... Usually it means -> it may work in certain/most cases but it may not work in others and thus the feature is labeled as "experimental" until all cases are sorted out....
IMHO, in this particular case while this is sorted out in the future version, it would be a good practise the user to be at least warned with some kind of a warning box (if he chooses a 3X, 2X image scale), that he will get a garbage result if the selected "Upscaling type" is not supporting the scale... Sorry but I do not think anyone reads a Wiki that often, maybe until he gets the garbage result..
It will be best of course, if there is an internal check of the supported by the rescale method scales, and when the user selects 3X, the app to list only the supported rescale types...
Anyway there is no way for the user to know by looking to the listed in app scale methods if the method supports the scale or not...
Anyway, thanks for the great work and efforts done with this app guys...
Lovely job

Experimental label is there because it only works with certain models, not all of them, definitely not the default ones. So it definitely works, just not the way a user would think it should work.

The new version already has warnings and links to wiki, so that's sorted :)

Hi,

I get the boxes regardless of any option, Even after a fresh install with not changing any settings, Just basic Ultramix or Real option. i get such boxes.

How can I get the simple working upscaly back? there is no option to turn off scale in settings either.

@aaronliu0130
Copy link
Member

Drag the scale slider completely to the right.

@martikyan
Copy link

I think this issue is somehow related to the invalid resolution. The resolution doesn't change if the experimental image slider is moved.

@aaronliu0130
Copy link
Member

I'm not sure what you mean by "invalid resolution".

@martikyan
Copy link

martikyan commented Jul 16, 2023

I'm not sure what you mean by "invalid resolution".

As you can see the target resolution is not the double of the original resolution, even though the image scale is set to 2x.

image image

@aaronliu0130
Copy link
Member

Are you sure that's not just a display error and the output file is that resolution?

@martikyan
Copy link

Are you sure that's not just a display error and the output file is that resolution?

Just checked. That's a UI bug. Perhaps the invalid resolution is being taken from UI and used in calculations? Is that possible?

@aaronliu0130
Copy link
Member

Probably not. Plus we already have another reason (the tiling) for why this happens.

@aaronliu0130
Copy link
Member

aaronliu0130 commented Aug 29, 2023

Note that this can also be due to not selecting the appropriate scale for a model, which in some cases like x1 is impossible. This has the same cause as this issue.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants