-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images look like a mixed up grid with the scale option #303
Comments
Well, that's why the scale option is labeled experimental 😅 This might be of use to you though: https://github.com/upscayl/custom-models |
I don't think the fact that this is experimental means that this isn't a bug. |
It's not a bug. The models are made for x4, to use other scales you have to use a compatible model (as mentioned in the custom models repository). |
I thought the 2x scale was what is had been originally. When I placed it back up to the 4x scale, it worked great. Thanks. |
I mean even though the models are made for x4, we should either fix that or use a different way, like downscaling the output |
That would be for some future version. Updated the wiki: |
Reopening as this is still planned for some future version. |
In my 15+ years of experience as a user and as a developer of OSS (with usage even of alfa versions apps), I've never encountered an application where "Experimental" meant a 100% fail result 😄 .... Usually it means -> it may work in certain/most cases but it may not work in others and thus the feature is labeled as "experimental" until all cases are sorted out.... IMHO, in this particular case while this is sorted out in the future version, it would be a good practise the user to be at least warned with some kind of a warning box (if he chooses a 3X, 2X image scale), that he will get a garbage result if the selected "Upscaling type" is not supporting the scale... Sorry but I do not think anyone reads a Wiki that often, maybe until he gets the garbage result.. Anyway, thanks for the great work and efforts done with this app guys... |
Experimental label is there because it only works with certain models, not all of them, definitely not the default ones. So it definitely works, just not the way a user would think it should work. The new version already has warnings and links to wiki, so that's sorted :) |
That's great ! Thanks a lot :) Keep up the great work and your great attitude to users ;) |
Hi, I get the boxes regardless of any option, Even after a fresh install with not changing any settings, Just basic Ultramix or Real option. i get such boxes. How can I get the simple working upscaly back? there is no option to turn off scale in settings either. |
Drag the scale slider completely to the right. |
I think this issue is somehow related to the invalid resolution. The resolution doesn't change if the experimental image slider is moved. |
I'm not sure what you mean by "invalid resolution". |
Are you sure that's not just a display error and the output file is that resolution? |
Just checked. That's a UI bug. Perhaps the invalid resolution is being taken from UI and used in calculations? Is that possible? |
Probably not. Plus we already have another reason (the tiling) for why this happens. |
Checklist
Describe the Bug
I select an image to upscayl, select digital art. (this issue happens with both jpg and png). The output image completely scrambles the original image. This just started a few minutes ago after the system forced an update to 2.5.1.
Logs
To Reproduce
I select an image to upscayl, select digital art. (this issue happens with both jpg and png). Select the Upscayl button. Wait for it to process. The output image completely scrambles the original image.
Expected Behavior
an upscayl replica of the original image.
Version/Commit Hash
2.5.1
OS Specifics
Win10
Screenshots
The text was updated successfully, but these errors were encountered: