Minor theme enhancements

[aaronliu0130]

Checklist

• I have checked that this issue isn't addressed in the FAQ.
• I have checked that this issue isn't addressed in any other issue or pull request.

Description

Multiple stuff:

1. Make the step two dropdown look like a dropdown
   
   
2. Many themes have poor contrast on the empty screen
   
   
   
   
   (maybe keep the halloween theme's part of this bug as a feature? it spooky)
   
   
   
   
   
   
   
   
   
   
   
   
3. Same images above: Save for Upscayl virtually all themes are unclear on the Save Image As part which extension is selected. When PNG is selected it seems like JPG is selected because JPG has the accent color.
4. add light version of Upscayl theme? If 5 isn't implemented the pastel theme seems like it'll fit the purpose
5. Get the system's accent color for the Upscayl theme's (and if we implement 4 that too's) accent color instead of always using purple
6. Center or maximize some elements?
7. Change "Select Upscayling Type" to "Select Upscayling Model"
   
8. Increase Coffee's overall contrast
   

Related Problem(s)

See above

Alternatives

everything is fine, this doesn't need to be implemented

[NayamAmarshe]

Thank you. I'll implement these suggestions.

[aaronliu0130]

From what I can see only points 2 and 7 were implemented?

[NayamAmarshe]

Oh yeah, sorry.

• 6 looks weird imo. Text and content must always be aligned and here, left alignment looks great.
• 8, that's DaisyUI's default coffee theme. So I suppose it'd be better to let them know about it.
• 5, this is very difficult. There's no standard way to do this, on all operating systems.
• 4 is for later :)

I've fixed the rest :)

[aaronliu0130]

Well, I think the model selection dropdown should be made as big as the theme selection dropdown at least

[NayamAmarshe]

Well, I think the model selection dropdown should be made as big as the theme selection dropdown at least

I didn't do it to keep design consistency in that column.

[aaronliu0130]

Well, IMO actual consistency would be to make every UI element look like the corresponding element in the theme; having a dropdown look like a button is inconsistency. Not to mention you already have an accented button, a toggle and a checkbox in that column.

[NayamAmarshe]

Well, IMO actual consistency would be to make every UI element look like the corresponding element in the theme; having a dropdown look like a button is inconsistency. Not to mention you already have an accented button, a toggle and a checkbox in that column.

The issue is that it's not necessarily a select menu like others. It's a custom component that also acts like an input field.

[aaronliu0130]

But the UI of it acts like a dropdown. Correct me if I'm wrong, but isn't all it takes is change the class name to select-primary select?

[aaronliu0130]

I accidently committed 62dd93b while trying to start a pull request...
I think the problem with 3 is the hacky way the selector is made to fit the upscayl theme. In that theme the primary color is a lighter shade of grey, though in other themes it's less background-y. So the button was accented, and both buttons were made primary (which I don't get).

This also makes it kinda inconsistent with the other UI elements, so I propose making accidently made only not-selected buttons primary.

[NayamAmarshe]

I accidently committed 62dd93b while trying to start a pull request... I think the problem with 3 is the hacky way the selector is made to fit the upscayl theme. In that theme the primary color is a lighter shade of grey, though in other themes it's less background-y. So the button was accented, and both buttons were made primary (which I don't get). This also makes it kinda inconsistent with the other UI elements, so I propose making accidently made only not-selected buttons primary.

Wait, but I fixed it already. I added a ring to the selected buttons.

[aaronliu0130]

My main problem was the colors

[NayamAmarshe]

My main problem was the colors

Ok, fixed it.