Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-Do #5

Closed
27 of 32 tasks
NayamAmarshe opened this issue Aug 18, 2022 · 14 comments
Closed
27 of 32 tasks

To-Do #5

NayamAmarshe opened this issue Aug 18, 2022 · 14 comments
Assignees

Comments

@NayamAmarshe
Copy link
Member

NayamAmarshe commented Aug 18, 2022

@aaronliu0130
Copy link
Member

Maybe this should be migrated to projects

@NayamAmarshe
Copy link
Member Author

Maybe this should be migrated to projects

I like it better this way, easier to access and manage.

@aaronliu0130
Copy link
Member

I think using github projects is better since it is easier to access them from linked issues, you can set milestones to them, and you can set the status and progress on it. It's also easier to edit and sort things there.

@NayamAmarshe
Copy link
Member Author

I think using github projects is better since it is easier to access them from linked issues, you can set milestones to them, and you can set the status and progress on it. It's also easier to edit and sort things there.

I know, I've used them before extensively but I honestly believe the issues workflow is better and faster, especially for a project of this size :)

@rufreakde
Copy link

hey I saw the TODO list and had a question to:
Allow Video Upscaling, detect ext and set model accordingly
will it be a CLI command where you pass a video file and an output file? Or is it also a UI thing?
Could write a bash script with it later on with such a functionality.

Very nice project! Directly Starred :)

@TGS963
Copy link
Member

TGS963 commented Sep 19, 2022

will it be a CLI command where you pass a video file and an output file? Or is it also a UI thing?

It will be a UI thing. We have already provided CLI binaries with their models in the resources folder. Those binaries can be directly used from CLI and video upscaling is already present in them as they are taken from Real-ESRGAN.
The video upscaling in the to-do list refers to the UI implementation that isn't present yet.

Thanks for the star :)

@rufreakde
Copy link

Sorry I see the FAQ just now!
Is there a CLI available? The CLI tool is called real-esrgan-ncnn-vulkan and it's available on the Real-ESRGAN repository. :)

@Jonas1999
Copy link

I really like this project, don't know if this is the place you want us to suggest changes/improvements but I'll put it here for now.
Some of these things I might help with and commit myself to the project in my spare time.

  • Have a toggle for replacing or skipping images with same name in target folder, if present
  • Show progress of total images processed in batch mode
  • (if possible) Remember last Input and Output folders individually
  • Pause/Resume/Cancel buttons for batch jobs
  • Select scaling factor in batch mode (2x, 4x, 8x for example)

@aaronliu0130
Copy link
Member

To suggest changes, you would usually open new issues.

@aaronliu0130
Copy link
Member

I guess we've migrated to https://github.com/orgs/upscayl/projects/1 !

@aaronliu0130
Copy link
Member

@NayamAmarshe Should we use milestones instead of version issue labels?

@NayamAmarshe
Copy link
Member Author

@NayamAmarshe Should we use milestones instead of version issue labels?

Are you talking about this issue? We're not using this To-Do list anymore😅

@aaronliu0130
Copy link
Member

I know, I"m talking about this GitHub feature called milestones. I think using version number issue labels is a bit confusing, and milestones can save the same purpose.

@NayamAmarshe
Copy link
Member Author

I know, I"m talking about this GitHub feature called milestones. I think using version number issue labels is a bit confusing, and milestones can save the same purpose.

I'll take a look, thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants