Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility for a Docker Image? #55

Closed
tomtom215 opened this issue Sep 2, 2022 · 7 comments
Closed

Possibility for a Docker Image? #55

tomtom215 opened this issue Sep 2, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@tomtom215
Copy link

Hello,

Your project is impressive! I see you mention Linux first philosophy and have provided binaries, but I was wondering if you'd make a docker image available?

Thanks!

@NayamAmarshe
Copy link
Member

I could make a docker file but I'm not sure what purpose would it serve.

@xinmans
Copy link

xinmans commented Jan 3, 2023

any update?

@NayamAmarshe
Copy link
Member

any update?

I personally don't have the time to look at Docker but I'll be okay with PRs for it :)

@nodecentral
Copy link

I could make a docker file but I'm not sure what purpose would it serve.

My home set up is basically an iPad and a NAS which I run a lot of containers to support video / photo work - having upscayl available via a Docker container make it available to me (as I don’t have windows, mac or Linux).

If you’re still considering doing it, I’d love to use it..

@aaronliu0130
Copy link
Member

aaronliu0130 commented Mar 11, 2023

@nodecentral Upscayl is a GUI for REAL-ERSGAN which already has lots of docker images https://hub.docker.com/search?q=real-esrgan https://hub.docker.com/search?q=esrgan

@xinmans
Copy link

xinmans commented May 10, 2023

I try to build myself, but failure


> upscayl@2.5.1 dev
> tsc && electron .
node:events:489
      throw er; // Unhandled 'error' event
      ^
Error: spawn /app/node_modules/electron/dist/electron ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:285:19)
    at onErrorNT (node:internal/child_process:483:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on ChildProcess instance at:
    at 3000._handle.onexit (node:internal/child_process:291:12)
    at onErrorNT (node:internal/child_process:483:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
�
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn /app/node_modules/electron/dist/electron',
  path: '/app/node_modules/electron/dist/electron',
  spawnargs: [ '.' ]
}
Node.js v20.1.0
  ```

Dockerfile

FROM node:alpine

RUN mkdir -p /app

WORKDIR /app

COPY package*.json ./

RUN npm install

COPY . .

EXPOSE 3000

CMD ["npm", "run", "dev"]

` docker-compose.yml 
version: "3.8"

networks:
  default:

services:
  app:
    container_name: upscayl
    build:
      context: .
      dockerfile: Dockerfile
    restart: unless-stopped
    ports:
      - 3000:3000
    networks:
      - default


    `

@nodecentral
Copy link

Hi @xinmans - I’ve not tried it yet, but I followed @aaronliu0130 advice and looked up some on Docker Hub and have this one to try at some point.. https://github.com/wpafbo79/ai-docker/tree/master/real-esrgan

@aaronliu0130 aaronliu0130 closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2023
@aaronliu0130 aaronliu0130 added the enhancement New feature or request label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants