Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc]: Rename all use of the word "annotations" with "markers" #21

Closed
rytswd opened this issue Jul 20, 2021 · 0 comments 路 Fixed by #24
Closed

[Misc]: Rename all use of the word "annotations" with "markers" #21

rytswd opened this issue Jul 20, 2021 · 0 comments 路 Fixed by #24

Comments

@rytswd
Copy link
Member

rytswd commented Jul 20, 2021

馃椇 Areas

Documentation

馃敄 Version

v0.0.1-rc4

馃攷 Details

The initial implementation started with the following terminologies

  • Importer Annotation
  • Export Marker

It is extremely inconsistent, and should consider consolidating, such as:

  • Importer Marker
  • Exporter Marker

This may also mean that we need to adjust the comment scheme around imptr and export.
This was referenced Jul 22, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename annotation to marker upsidr/importer
1 participant
@rytswd